atlas-dev mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From "Shwetha GS" <sshivalingamur...@hortonworks.com>
Subject Re: Review Request 37349: ATLAS-91 Add solr configuration and documentation
Date Wed, 12 Aug 2015 04:23:42 GMT


> On Aug. 11, 2015, 6:49 p.m., Seetharam Venkatesh wrote:
> > repository/src/main/java/org/apache/atlas/repository/graph/Solr5Index.java, line
19
> > <https://reviews.apache.org/r/37349/diff/1/?file=1037524#file1037524line19>
> >
> >     Why cant I retain the titan package here? Dont you think this becomes confusing?

Yes, we can retain the package name. But I don't think it will be any less confusing


> On Aug. 11, 2015, 6:49 p.m., Seetharam Venkatesh wrote:
> > repository/src/main/java/org/apache/atlas/repository/graph/Solr5Index.java, line
101
> > <https://reviews.apache.org/r/37349/diff/1/?file=1037524#file1037524line101>
> >
> >     Seriously? :-)

What else can we do when we copy the code?


> On Aug. 11, 2015, 6:49 p.m., Seetharam Venkatesh wrote:
> > src/conf/solr/currency.xml, line 1
> > <https://reviews.apache.org/r/37349/diff/1/?file=1037526#file1037526line1>
> >
> >     Why cant this be repurposed from Titan-solr buindling?

Its not part of titan-solr jar


- Shwetha


-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/37349/#review94961
-----------------------------------------------------------


On Aug. 11, 2015, 9:32 a.m., Shwetha GS wrote:
> 
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/37349/
> -----------------------------------------------------------
> 
> (Updated Aug. 11, 2015, 9:32 a.m.)
> 
> 
> Review request for atlas.
> 
> 
> Bugs: ATLAS-91
>     https://issues.apache.org/jira/browse/ATLAS-91
> 
> 
> Repository: atlas
> 
> 
> Description
> -------
> 
> Copied SolrIndex.java from titan codebase to atlas to support solr5 with titan 0.5.4.
Added function using reflection to override atlas's SolrIndex
> 
> 
> Diffs
> -----
> 
>   client/pom.xml d393b3a 
>   docs/src/site/twiki/InstallationSteps.twiki 0391c2d 
>   pom.xml facd539 
>   repository/pom.xml a2f8e08 
>   repository/src/main/java/org/apache/atlas/repository/graph/Solr5Index.java PRE-CREATION

>   repository/src/main/java/org/apache/atlas/repository/graph/TitanGraphProvider.java
5e61b9a 
>   src/conf/solr/currency.xml PRE-CREATION 
>   src/conf/solr/lang/stopwords_en.txt PRE-CREATION 
>   src/conf/solr/protwords.txt PRE-CREATION 
>   src/conf/solr/schema.xml PRE-CREATION 
>   src/conf/solr/solrconfig.xml PRE-CREATION 
>   src/conf/solr/stopwords.txt PRE-CREATION 
>   src/conf/solr/synonyms.txt PRE-CREATION 
> 
> Diff: https://reviews.apache.org/r/37349/diff/
> 
> 
> Testing
> -------
> 
> UTs in distributed profile
> 
> 
> Thanks,
> 
> Shwetha GS
> 
>


Mime
  • Unnamed multipart/alternative (inline, None, 0 bytes)
View raw message