atlas-dev mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From "Shwetha GS" <sshivalingamur...@hortonworks.com>
Subject Re: Review Request 36611: ATLAS-74 Create notification framework
Date Tue, 21 Jul 2015 07:13:13 GMT


> On July 20, 2015, 11:16 p.m., Seetharam Venkatesh wrote:
> > notification/src/main/java/org/apache/atlas/notification/NotificationModule.java,
line 26
> > <https://reviews.apache.org/r/36611/diff/1/?file=1016160#file1016160line26>
> >
> >     Is there a way to externalize this? How do folks say wrap another implementaiton
- for future.
> 
> Shwetha GS wrote:
>     I didn't want to add to just config as we use Guice everywhere. Add to config and
use that in Guice? Makes sense, will change.

Can I add this once we merge client and application properties? Wil do it soon. Currently,
Guice is the way to go


- Shwetha


-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/36611/#review92333
-----------------------------------------------------------


On July 20, 2015, 6:14 a.m., Shwetha GS wrote:
> 
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/36611/
> -----------------------------------------------------------
> 
> (Updated July 20, 2015, 6:14 a.m.)
> 
> 
> Review request for atlas.
> 
> 
> Bugs: ATLAS-74
>     https://issues.apache.org/jira/browse/ATLAS-74
> 
> 
> Repository: atlas
> 
> 
> Description
> -------
> 
> Add notification framework with kafka as default implementation
> 
> 
> Diffs
> -----
> 
>   client/src/main/java/org/apache/atlas/PropertiesUtil.java bc56cbf 
>   notification/pom.xml PRE-CREATION 
>   notification/src/main/java/org/apache/atlas/kafka/KafkaConsumer.java PRE-CREATION 
>   notification/src/main/java/org/apache/atlas/kafka/KafkaNotification.java PRE-CREATION

>   notification/src/main/java/org/apache/atlas/notification/ConsumerInterface.java PRE-CREATION

>   notification/src/main/java/org/apache/atlas/notification/NotificationException.java
PRE-CREATION 
>   notification/src/main/java/org/apache/atlas/notification/NotificationHookConsumer.java
PRE-CREATION 
>   notification/src/main/java/org/apache/atlas/notification/NotificationInterface.java
PRE-CREATION 
>   notification/src/main/java/org/apache/atlas/notification/NotificationModule.java PRE-CREATION

>   notification/src/test/java/org/apache/atlas/kafka/kafkaNotificationTest.java PRE-CREATION

>   pom.xml 6e7c10c 
>   src/conf/application.properties 6c4c7d2 
>   typesystem/src/main/resources/application.properties 29c933f 
>   typesystem/src/main/resources/log4j.xml 742f674 
>   webapp/src/main/java/org/apache/atlas/Main.java 1dd17b4 
>   webapp/src/main/java/org/apache/atlas/web/service/EmbeddedServer.java 88200f0 
>   webapp/src/main/resources/application.properties c9b8408 
> 
> Diff: https://reviews.apache.org/r/36611/diff/
> 
> 
> Testing
> -------
> 
> UTs
> 
> 
> Thanks,
> 
> Shwetha GS
> 
>


Mime
  • Unnamed multipart/alternative (inline, None, 0 bytes)
View raw message