atlas-dev mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From "Seetharam Venkatesh" <venkat...@innerzeal.com>
Subject Re: Review Request 36611: ATLAS-74 Create notification framework
Date Mon, 20 Jul 2015 23:16:13 GMT

-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/36611/#review92333
-----------------------------------------------------------



client/src/main/java/org/apache/atlas/PropertiesUtil.java (line 42)
<https://reviews.apache.org/r/36611/#comment146432>

    Merge may have conflicts, no? Isnt this dangerous? Why cant we treat this separate configs?



client/src/main/java/org/apache/atlas/PropertiesUtil.java (line 66)
<https://reviews.apache.org/r/36611/#comment146433>

    ternary operator?



notification/src/main/java/org/apache/atlas/notification/ConsumerInterface.java (line 20)
<https://reviews.apache.org/r/36611/#comment146434>

    Seriously, suffix with Interface? :-)
    
    How close is this to JMS?



notification/src/main/java/org/apache/atlas/notification/NotificationHookConsumer.java (line
66)
<https://reviews.apache.org/r/36611/#comment146435>

    There is an implicit assumption that we always create the entity json and put it in the
broker? 
    
    Should we verify the layload?



notification/src/main/java/org/apache/atlas/notification/NotificationInterface.java (line
26)
<https://reviews.apache.org/r/36611/#comment146436>

    Seriously, suffix with Interface? :-)



notification/src/main/java/org/apache/atlas/notification/NotificationInterface.java (line
33)
<https://reviews.apache.org/r/36611/#comment146437>

    Should we also allow Traits as a specific notofication type? 
    
    Hook generalizes all components - do we need anything specific here? Cant think of any
ATM



notification/src/main/java/org/apache/atlas/notification/NotificationModule.java (line 26)
<https://reviews.apache.org/r/36611/#comment146438>

    Is there a way to externalize this? How do folks say wrap another implementaiton - for
future.



notification/src/test/java/org/apache/atlas/kafka/kafkaNotificationTest.java (line 35)
<https://reviews.apache.org/r/36611/#comment146439>

    Name starts with lowercase.



pom.xml (line 976)
<https://reviews.apache.org/r/36611/#comment146431>

    Why is this necessary?



src/conf/application.properties (line 32)
<https://reviews.apache.org/r/36611/#comment146440>

    Dont we need the notification impl type here which can be used in Guice?


- Seetharam Venkatesh


On July 20, 2015, 6:14 a.m., Shwetha GS wrote:
> 
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/36611/
> -----------------------------------------------------------
> 
> (Updated July 20, 2015, 6:14 a.m.)
> 
> 
> Review request for atlas.
> 
> 
> Bugs: ATLAS-74
>     https://issues.apache.org/jira/browse/ATLAS-74
> 
> 
> Repository: atlas
> 
> 
> Description
> -------
> 
> Add notification framework with kafka as default implementation
> 
> 
> Diffs
> -----
> 
>   client/src/main/java/org/apache/atlas/PropertiesUtil.java bc56cbf 
>   notification/pom.xml PRE-CREATION 
>   notification/src/main/java/org/apache/atlas/kafka/KafkaConsumer.java PRE-CREATION 
>   notification/src/main/java/org/apache/atlas/kafka/KafkaNotification.java PRE-CREATION

>   notification/src/main/java/org/apache/atlas/notification/ConsumerInterface.java PRE-CREATION

>   notification/src/main/java/org/apache/atlas/notification/NotificationException.java
PRE-CREATION 
>   notification/src/main/java/org/apache/atlas/notification/NotificationHookConsumer.java
PRE-CREATION 
>   notification/src/main/java/org/apache/atlas/notification/NotificationInterface.java
PRE-CREATION 
>   notification/src/main/java/org/apache/atlas/notification/NotificationModule.java PRE-CREATION

>   notification/src/test/java/org/apache/atlas/kafka/kafkaNotificationTest.java PRE-CREATION

>   pom.xml 6e7c10c 
>   src/conf/application.properties 6c4c7d2 
>   typesystem/src/main/resources/application.properties 29c933f 
>   typesystem/src/main/resources/log4j.xml 742f674 
>   webapp/src/main/java/org/apache/atlas/Main.java 1dd17b4 
>   webapp/src/main/java/org/apache/atlas/web/service/EmbeddedServer.java 88200f0 
>   webapp/src/main/resources/application.properties c9b8408 
> 
> Diff: https://reviews.apache.org/r/36611/diff/
> 
> 
> Testing
> -------
> 
> UTs
> 
> 
> Thanks,
> 
> Shwetha GS
> 
>


Mime
  • Unnamed multipart/alternative (inline, None, 0 bytes)
View raw message