atlas-dev mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From "Suma Shivaprasad" <sumasai.shivapra...@gmail.com>
Subject Re: Review Request 36550: Integration with Hbase and solr
Date Mon, 20 Jul 2015 09:45:39 GMT


> On July 17, 2015, 1:18 p.m., Jonathan Maron wrote:
> > I'm curious about the switch from mortbay to eclipse for the jetty plugin?  Was
it a configuraiton convenience issue?  Any differences between the two that we should test
to ensure no loss of functionality?

I had issues getting any documentation o the source code for jetty 6 since the codehaus site
has been deprecated. Also I had challenges with getting jetty 6 to override the web.xml for
tests with the documented configs. 

Jetty 6,7,8 have been EOLed already - http://dev.eclipse.org/mhonarc/lists/jetty-announce/msg00069.html.
Hence decided to upgrade it to 9.


Wrt major changes, please review the changes corresponding to SecureEmbeddedServer. The APIs
for setting up https(SSLContextFactory instead of SSLSocketListener) have changed and I had
to migrate to that while upgrading to the new jetty. These need to be tested. Currently all
the tests except the security tests in hive hook are failing and would need your help to resolve
them.


- Suma


-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/36550/#review92075
-----------------------------------------------------------


On July 17, 2015, 1:12 p.m., Suma Shivaprasad wrote:
> 
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/36550/
> -----------------------------------------------------------
> 
> (Updated July 17, 2015, 1:12 p.m.)
> 
> 
> Review request for atlas, Jonathan Maron, Shwetha GS, and Seetharam Venkatesh.
> 
> 
> Bugs: ATLAS-37
>     https://issues.apache.org/jira/browse/ATLAS-37
> 
> 
> Repository: atlas
> 
> 
> Description
> -------
> 
> Fixed dependencies and code, tests for Titan to work with Hbase and solr
> 
> 
> Diffs
> -----
> 
>   addons/hive-bridge/pom.xml 2617aeb 
>   addons/hive-bridge/src/test/java/org/apache/atlas/hive/hook/BaseSSLAndKerberosTest.java
5ae6fe2 
>   addons/hive-bridge/src/test/java/org/apache/atlas/hive/hook/NegativeSSLAndKerberosHiveHookIT.java
629a9f3 
>   addons/hive-bridge/src/test/java/org/apache/atlas/hive/hook/SSLAndKerberosHiveHookIT.java
b8f29aa 
>   addons/hive-bridge/src/test/java/org/apache/atlas/hive/hook/SSLHiveHookIT.java 54bfaf6

>   addons/hive-bridge/src/test/resources/application.properties 50eefed 
>   client/src/test/java/org/apache/atlas/security/BaseSecurityTest.java 598f56b 
>   pom.xml 6e7c10c 
>   repository/pom.xml b23c289 
>   repository/src/main/java/org/apache/atlas/RepositoryMetadataModule.java e7353f9 
>   repository/src/main/java/org/apache/atlas/repository/graph/GraphProvider.java 5472081

>   repository/src/main/java/org/apache/atlas/repository/graph/TitanGraphProvider.java
3c1d151 
>   repository/src/main/java/org/apache/atlas/services/DefaultMetadataService.java 9556272

>   repository/src/test/java/org/apache/atlas/RepositoryServiceLoadingTest.java 4195955

>   repository/src/test/java/org/apache/atlas/discovery/GraphBackedDiscoveryServiceTest.java
67cdd78 
>   repository/src/test/java/org/apache/atlas/discovery/HiveLineageServiceTest.java ce00f8c

>   repository/src/test/java/org/apache/atlas/repository/graph/GraphBackedMetadataRepositoryTest.java
fb697d0 
>   repository/src/test/java/org/apache/atlas/repository/typestore/GraphBackedTypeStoreTest.java
c774123 
>   repository/src/test/resources/application.properties 20c0c51 
>   src/conf/application.properties c6b16cc 
>   webapp/pom.xml 0ae4a05 
>   webapp/src/main/java/org/apache/atlas/web/listeners/GuiceServletConfig.java 18ce17c

>   webapp/src/main/java/org/apache/atlas/web/service/EmbeddedServer.java 88200f0 
>   webapp/src/main/java/org/apache/atlas/web/service/SecureEmbeddedServer.java 174dafb

>   webapp/src/main/resources/application.properties c9b8408 
>   webapp/src/test/java/org/apache/atlas/web/filters/MetadataAuthenticationKerberosFilterIT.java
95acc57 
>   webapp/src/test/java/org/apache/atlas/web/filters/MetadataAuthenticationSimpleFilterIT.java
5ea2e15 
>   webapp/src/test/java/org/apache/atlas/web/listeners/LoginProcessorIT.java 54a7a7b 
>   webapp/src/test/java/org/apache/atlas/web/listeners/TestGuiceServletConfig.java PRE-CREATION

>   webapp/src/test/java/org/apache/atlas/web/security/BaseSecurityTest.java PRE-CREATION

>   webapp/src/test/java/org/apache/atlas/web/service/SecureEmbeddedServerIT.java 3e27532

>   webapp/src/test/java/org/apache/atlas/web/service/SecureEmbeddedServerITBase.java db110ca

>   webapp/src/test/webapp/WEB-INF/web.xml PRE-CREATION 
> 
> Diff: https://reviews.apache.org/r/36550/diff/
> 
> 
> Testing
> -------
> 
> Ran all UTs and ITS. Except the hive hook security Its, all other tests succeed.
> 
> 
> Thanks,
> 
> Suma Shivaprasad
> 
>


Mime
  • Unnamed multipart/alternative (inline, None, 0 bytes)
View raw message