atlas-dev mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From "Suma Shivaprasad" <sumasai.shivapra...@gmail.com>
Subject Re: Review Request 35645: ATLAS-3 - Mixed Index creation fails with Date types on ElasticSearch index backend
Date Mon, 22 Jun 2015 10:34:07 GMT

-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/35645/
-----------------------------------------------------------

(Updated June 22, 2015, 10:34 a.m.)


Review request for atlas.


Changes
-------

Had missed changes to convert from Date to long and was doing to String instead. Fixed that
and also made UTs less brittle by removing traisnet id comparisions


Bugs: ATLAS-3
    https://issues.apache.org/jira/browse/ATLAS-3


Repository: atlas


Description
-------

ATLAS-3 - Mixed Index creation fails with Date types on ElasticSearch index backend


Diffs (updated)
-----

  pom.xml 6e7b470 
  repository/pom.xml e885f76 
  repository/src/main/java/org/apache/atlas/repository/graph/GraphBackedMetadataRepository.java
dbee992 
  repository/src/main/java/org/apache/atlas/repository/graph/GraphBackedSearchIndexer.java
3e6edb6 
  repository/src/main/scala/org/apache/atlas/query/Expressions.scala 7c5c2b5 
  repository/src/main/scala/org/apache/atlas/query/GraphPersistenceStrategies.scala b475407

  repository/src/main/scala/org/apache/atlas/query/GremlinQuery.scala 914ed7a 
  repository/src/test/java/org/apache/atlas/discovery/GraphBackedDiscoveryServiceTest.java
fc07010 
  repository/src/test/java/org/apache/atlas/repository/graph/GraphRepoMapperScaleTest.java
01b7480 
  repository/src/test/scala/org/apache/atlas/query/GremlinTest.scala aa41313 
  repository/src/test/scala/org/apache/atlas/query/HiveTitanSample.scala 71cbad3 
  repository/src/test/scala/org/apache/atlas/query/LineageQueryTest.scala 58f3d98 
  repository/src/test/scala/org/apache/atlas/query/QueryTestsUtils.scala d79758a 
  typesystem/src/main/java/org/apache/atlas/typesystem/types/TypeSystem.java 0d0c783 

Diff: https://reviews.apache.org/r/35645/diff/


Testing
-------

Added 2 tests abd verified that mixed index is getting picked up


Thanks,

Suma Shivaprasad


Mime
  • Unnamed multipart/alternative (inline, None, 0 bytes)
View raw message