Mailing-List: contact commits-help@atlas.incubator.apache.org; run by ezmlm
Precedence: bulk
Reply-To: dev@atlas.incubator.apache.org
Content-Type: text/plain; charset="us-ascii"
MIME-Version: 1.0
Content-Transfer-Encoding: 7bit
From: shwethags@apache.org
To: commits@atlas.incubator.apache.org
Date: Wed, 24 Feb 2016 04:39:37 -0000
Message-Id: <960dca24e4314b83bec3ad034f1727b9@git.apache.org>
Subject: [1/2] incubator-atlas git commit: ATLAS-364 UI Code standardization
 (darshankumar89 via shwethags)

Repository: incubator-atlas
Updated Branches:
  refs/heads/master 999219300 -> ecd0f6105


http://git-wip-us.apache.org/repos/asf/incubator-atlas/blob/ecd0f610/dashboard/public/modules/tags/tagClasses.js
----------------------------------------------------------------------
diff --git a/dashboard/public/modules/tags/tagClasses.js b/dashboard/public/modules/tags/tagClasses.js
index 416acaa..6bbbad3 100644
--- a/dashboard/public/modules/tags/tagClasses.js
+++ b/dashboard/public/modules/tags/tagClasses.js
@@ -18,7 +18,7 @@
 
 'use strict';
 
-angular.module('dgc.tags').factory('TagClasses', ['lodash', function ClassFactory(_) {
+angular.module('dgc.tags').factory('tagClasses', ['lodash', function classFactory(_) {
 
     function Tag(props) {
         return _.merge({
@@ -47,7 +47,7 @@ angular.module('dgc.tags').factory('TagClasses', ['lodash', function ClassFactor
         this.id = classId;
         this.name = className;
 
-        this.addTag = function AddTag(props) {
+        this.addTag = function addTag(props) {
             var tag = new Tag(_.merge({
                 hierarchicalMetaTypeName: className
             }, props));
@@ -56,12 +56,12 @@ angular.module('dgc.tags').factory('TagClasses', ['lodash', function ClassFactor
             return this;
         };
 
-        this.clearTags = function RemoveTags() {
+        this.clearTags = function removeTags() {
             this.tags = [];
             return this;
         };
 
-        this.toJson = function CreateJson() {
+        this.toJson = function createJson() {
             var classTypeKey = (this.id.toLowerCase() + 'Types'),
                 output = {};
 
@@ -79,7 +79,7 @@ angular.module('dgc.tags').factory('TagClasses', ['lodash', function ClassFactor
     }
 
     return _.chain(classes)
-        .map(function CreateClass(className, classId) {
+        .map(function createClass(className, classId) {
             return new Class(classId, className);
         })
         .indexBy('id')

http://git-wip-us.apache.org/repos/asf/incubator-atlas/blob/ecd0f610/dashboard/public/modules/tags/tagsResource.js
----------------------------------------------------------------------
diff --git a/dashboard/public/modules/tags/tagsResource.js b/dashboard/public/modules/tags/tagsResource.js
index 98a636b..02c0481 100755
--- a/dashboard/public/modules/tags/tagsResource.js
+++ b/dashboard/public/modules/tags/tagsResource.js
@@ -18,8 +18,8 @@
 
 'use strict';
 
-angular.module('dgc.tags').factory('TagsResource', ['$resource', 'AtlasConfig', function($resource, AtlasConfig) {
-    return $resource(AtlasConfig.API_ENDPOINTS.CREATE_TRAIT + '/:id', {}, {
+angular.module('dgc.tags').factory('tagsResource', ['$resource', 'atlasConfig', function($resource, atlasConfig) {
+    return $resource(atlasConfig.API_ENDPOINTS.CREATE_TRAIT + '/:id', {}, {
         query: {
             method: 'GET',
             transformResponse: function(data) {

http://git-wip-us.apache.org/repos/asf/incubator-atlas/blob/ecd0f610/dashboard/public/modules/tags/tagsRoutes.js
----------------------------------------------------------------------
diff --git a/dashboard/public/modules/tags/tagsRoutes.js b/dashboard/public/modules/tags/tagsRoutes.js
index 1359931..ebe1e87 100755
--- a/dashboard/public/modules/tags/tagsRoutes.js
+++ b/dashboard/public/modules/tags/tagsRoutes.js
@@ -28,16 +28,16 @@ angular.module('dgc.tags').config(['$stateProvider',
             parent: 'details',
             params: {
                 tId: null,
-                frm : 'addTag'
+                frm: 'addTag'
             },
-            onEnter: ['$stateParams', '$state', '$modal', 'NavigationResource', function($stateParams, $state, $modal, NavigationResource) {
+            onEnter: ['$stateParams', '$state', '$modal', 'navigationResource', function($stateParams, $state, $modal, navigationResource) {
                 $modal.open({
                     templateUrl: '/modules/tags/instance/views/createTag.html',
-                    controller: 'CreateTagController',
+                    controller: 'createTagController',
                     windowClass: 'create-tag-entity',
                     resolve: {
                         typesList: function() {
-                            return NavigationResource.get().$promise;
+                            return navigationResource.get().$promise;
                         }
                     }
                 }).result.finally(function() {

http://git-wip-us.apache.org/repos/asf/incubator-atlas/blob/ecd0f610/release-log.txt
----------------------------------------------------------------------
diff --git a/release-log.txt b/release-log.txt
index 90076d3..638911e 100644
--- a/release-log.txt
+++ b/release-log.txt
@@ -9,6 +9,7 @@ ATLAS-409 Atlas will not import avro tables with schema read from a file (dosset
 ATLAS-379 Create sqoop and falcon metadata addons (venkatnrangan,bvellanki,sowmyaramesh via shwethags)
 
 ALL CHANGES:
+ATLAS-364 UI Code standardization (darshankumar89 via shwethags)
 ATLAS_396 Creating an entity with non-existing type results in "Unable to deserialize json" error (guptaneeru via sumasai)
 ATLAS-318 Config file conatining API endpoint + all api calls to be centralized (sanjayp via sumasai)
 ATLAS-471 Atlas Server could run out of memory due to Scala memory leak (yhemanth via sumasai)