Mailing-List: contact users-help@asterixdb.incubator.apache.org; run by ezmlm
Precedence: bulk
Reply-To: users@asterixdb.incubator.apache.org
Received-SPF: error (nike.apache.org: local policy)
MIME-Version: 1.0
In-Reply-To: 
 <CAEAtgj6bVX55pxjy-+6_RmbD5zHZ2P9x6GOrR3bdR7SX6kcq3w@mail.gmail.com>
References: 
 <CAEAtgj6bVX55pxjy-+6_RmbD5zHZ2P9x6GOrR3bdR7SX6kcq3w@mail.gmail.com>
From: Ian Maxon <imaxon@uci.edu>
Date: Mon, 8 Jun 2015 11:33:20 -0700
Message-ID: 
 <CAN_YF5zi2s0YfQ_gBaxrrZuV_NekpTij7LNeiqBWKQNs6um+UQ@mail.gmail.com>
Subject: Re: REST API error code question for Invalid Statements (API docs
 nitpick)
To: asterixdb-users@googlegroups.com
Cc: users@asterixdb.incubator.apache.org
Content-Type: multipart/alternative; boundary=20cf303635457f4366051805e1ec

--20cf303635457f4366051805e1ec
Content-Type: text/plain; charset=UTF-8

Hey Eugenia,

Good catch. This is certainly a bug.
Regarding the classification of exceptions,HyracksException and
HyracksDataException are pretty broad. It can be anything from network to
disk to "this shouldn't happen" type of exceptions.
It would be interesting to see if that erroneous query had it's exception
casted into something else along the way, or if it just threw an exception
that wasn't anticipated as one that would be returned for a bad query.

- Ian

On Mon, Jun 8, 2015 at 12:44 AM, Eugenia Gabrielova <
genia.likes.science@gmail.com> wrote:

> Hello! This is a docs/code matchup nitpick question.
>
> *Question: *Reality or docs: which is correct error-code for Invalid
> Statements submitted to AsterixDB REST API? Why aren't Algebricks and
> Hyracks Exceptions documented in the REST API, though they have their own
> error-codes?
>
> *Version: *0.8.7 Master
>
> *Proposed Solutions: *Add an error code for instances of
> AsterixException, and/or update API docs to reflect actual behavior.
>
> *Details: *Working on some test cases for errors for the JS SDK.
> According to the REST API docs (
> https://asterixdb.ics.uci.edu/documentation/api.html), a REST API call
> with an Invalid Statement should return error-code 1.
>
> When I submit a query statement to the DDL endpoint, I observe error code
> 99.
>
> *use dataverse test_company;*
> *for $ds in dataset Metadata.Dataset return $ds;*
>  [*99*,
>   'Invalid statement: Non-DDL statement QUERY to the DDL API.
> [AsterixException]' ]
>
> *What I've tried so far: *I noticed in
> *asterix-app/src/main/java/edu/uci/ics/asterix/result/ResultUtils.java* that
> an Invalid Statement error-code 1 is not set, so the 99 code I am observing
> makes sense. I also noticed that Algebricks and Hyracks exceptions are not
> *210     public static void apiErrorHandler(PrintWriter out, Exception e)
> {*
> *211         int errorCode = 99;*
> *212         if (e instanceof ParseException) {*
> *213             errorCode = 2;*
> *214         } else if (e instanceof AlgebricksException) {*
> *215             errorCode = 3;*
> *216         } else if (e instanceof HyracksDataException) {*
> *217             errorCode = 4;*
> *218         }*
>
> Thanks!
> Eugenia
>
>  --
> You received this message because you are subscribed to the Google Groups
> "asterixdb-users" group.
> To unsubscribe from this group and stop receiving emails from it, send an
> email to asterixdb-users+unsubscribe@googlegroups.com.
> For more options, visit https://groups.google.com/d/optout.
>

--20cf303635457f4366051805e1ec
Content-Type: text/html; charset=UTF-8
Content-Transfer-Encoding: quoted-printable

<div dir=3D"ltr">Hey Eugenia,<div><br></div><div>Good catch. This is certai=
nly a bug.=C2=A0</div><div>Regarding the classification of exceptions,Hyrac=
ksException and HyracksDataException are pretty broad. It can be anything f=
rom network to disk to &quot;this shouldn&#39;t happen&quot; type of except=
ions.=C2=A0</div><div>It would be interesting to see if that erroneous quer=
y had it&#39;s exception casted into something else along the way, or if it=
 just threw an exception that wasn&#39;t anticipated as one that would be r=
eturned for a bad query.</div><div><br></div><div>- Ian</div></div><div cla=
ss=3D"gmail_extra"><br><div class=3D"gmail_quote">On Mon, Jun 8, 2015 at 12=
:44 AM, Eugenia Gabrielova <span dir=3D"ltr">&lt;<a href=3D"mailto:genia.li=
kes.science@gmail.com" target=3D"_blank">genia.likes.science@gmail.com</a>&=
gt;</span> wrote:<br><blockquote class=3D"gmail_quote" style=3D"margin:0 0 =
0 .8ex;border-left:1px #ccc solid;padding-left:1ex"><div dir=3D"ltr">Hello!=
 This is a docs/code matchup nitpick question.<div><br></div><div><b>Questi=
on: </b>Reality or docs: which=C2=A0is correct error-code for Invalid State=
ments submitted to AsterixDB REST API? Why aren&#39;t Algebricks and Hyrack=
s Exceptions documented in the REST API, though they have their own error-c=
odes?=C2=A0</div><div><br></div><div><b>Version: </b>0.8.7 Master</div><div=
><br></div><div><b>Proposed Solutions: </b>Add an=C2=A0error code for insta=
nces of AsterixException, and/or update API docs to reflect actual behavior=
.</div><div><br></div><div><b>Details:=C2=A0</b>Working on some test cases =
for errors for the JS SDK. According to the REST API docs (<a href=3D"https=
://asterixdb.ics.uci.edu/documentation/api.html" target=3D"_blank">https://=
asterixdb.ics.uci.edu/documentation/api.html</a>), a REST API call with an =
Invalid Statement should return error-code 1.<br></div><div><br></div><div>=
When I submit a query statement to the DDL endpoint, I observe error code 9=
9.</div><div><br></div><div><div><i>use dataverse test_company;</i></div><d=
iv><i>for $ds in dataset Metadata.Dataset return $ds;</i></div></div><div><=
div>=C2=A0[<b>99</b>,</div><div>=C2=A0 &#39;Invalid statement: Non-DDL stat=
ement QUERY to the DDL API. [AsterixException]&#39; ]</div></div><div><br><=
/div><div><b>What I&#39;ve tried so far: </b>I noticed in <b>asterix-app/sr=
c/main/java/edu/uci/ics/asterix/result/ResultUtils.java</b>=C2=A0that an In=
valid Statement error-code 1 is not set, so the 99 code I am observing make=
s sense. I also noticed that Algebricks and Hyracks exceptions are not=C2=
=A0</div><div><div><i>210 =C2=A0 =C2=A0 public static void apiErrorHandler(=
PrintWriter out, Exception e) {</i></div><div><i>211 =C2=A0 =C2=A0 =C2=A0 =
=C2=A0 int errorCode =3D 99;</i></div><div><i>212 =C2=A0 =C2=A0 =C2=A0 =C2=
=A0 if (e instanceof ParseException) {</i></div><div><i>213 =C2=A0 =C2=A0 =
=C2=A0 =C2=A0 =C2=A0 =C2=A0 errorCode =3D 2;</i></div><div><i>214 =C2=A0 =
=C2=A0 =C2=A0 =C2=A0 } else if (e instanceof AlgebricksException) {</i></di=
v><div><i>215 =C2=A0 =C2=A0 =C2=A0 =C2=A0 =C2=A0 =C2=A0 errorCode =3D 3;</i=
></div><div><i>216 =C2=A0 =C2=A0 =C2=A0 =C2=A0 } else if (e instanceof Hyra=
cksDataException) {</i></div><div><i>217 =C2=A0 =C2=A0 =C2=A0 =C2=A0 =C2=A0=
 =C2=A0 errorCode =3D 4;</i></div><div><i>218 =C2=A0 =C2=A0 =C2=A0 =C2=A0 }=
</i></div></div><div><br></div><div>Thanks!</div><span class=3D"HOEnZb"><fo=
nt color=3D"#888888"><div>Eugenia</div><div><br></div></font></span></div><=
span class=3D"HOEnZb"><font color=3D"#888888">

<p></p>

-- <br>
You received this message because you are subscribed to the Google Groups &=
quot;asterixdb-users&quot; group.<br>
To unsubscribe from this group and stop receiving emails from it, send an e=
mail to <a href=3D"mailto:asterixdb-users+unsubscribe@googlegroups.com" tar=
get=3D"_blank">asterixdb-users+unsubscribe@googlegroups.com</a>.<br>
For more options, visit <a href=3D"https://groups.google.com/d/optout" targ=
et=3D"_blank">https://groups.google.com/d/optout</a>.<br>
</font></span></blockquote></div><br></div>

--20cf303635457f4366051805e1ec--