From notifications-return-147580-archive-asf-public=cust-asf.ponee.io@asterixdb.apache.org Thu May 9 18:36:15 2019 Return-Path: X-Original-To: archive-asf-public@cust-asf.ponee.io Delivered-To: archive-asf-public@cust-asf.ponee.io Received: from mail.apache.org (hermes.apache.org [207.244.88.153]) by mx-eu-01.ponee.io (Postfix) with SMTP id AEAD8180649 for ; Thu, 9 May 2019 20:36:14 +0200 (CEST) Received: (qmail 86414 invoked by uid 500); 9 May 2019 18:36:14 -0000 Mailing-List: contact notifications-help@asterixdb.apache.org; run by ezmlm Precedence: bulk List-Help: List-Unsubscribe: List-Post: List-Id: Reply-To: dev@asterixdb.apache.org Delivered-To: mailing list notifications@asterixdb.apache.org Received: (qmail 86397 invoked by uid 99); 9 May 2019 18:36:14 -0000 Received: from pnap-us-west-generic-nat.apache.org (HELO spamd4-us-west.apache.org) (209.188.14.142) by apache.org (qpsmtpd/0.29) with ESMTP; Thu, 09 May 2019 18:36:14 +0000 Received: from localhost (localhost [127.0.0.1]) by spamd4-us-west.apache.org (ASF Mail Server at spamd4-us-west.apache.org) with ESMTP id 967F6C00CF; Thu, 9 May 2019 18:36:13 +0000 (UTC) X-Virus-Scanned: Debian amavisd-new at spamd4-us-west.apache.org X-Spam-Flag: NO X-Spam-Score: 4.127 X-Spam-Level: **** X-Spam-Status: No, score=4.127 tagged_above=-999 required=6.31 tests=[HTML_MESSAGE=2, MISSING_HEADERS=1.207, SPF_FAIL=0.919, URIBL_BLOCKED=0.001] autolearn=disabled Received: from mx1-lw-us.apache.org ([10.40.0.8]) by localhost (spamd4-us-west.apache.org [10.40.0.11]) (amavisd-new, port 10024) with ESMTP id UEJUbfCaw6FR; Thu, 9 May 2019 18:36:11 +0000 (UTC) Received: from adrian-monk-v3.ics.uci.edu (adrian-monk-v3.ics.uci.edu [128.195.1.133]) by mx1-lw-us.apache.org (ASF Mail Server at mx1-lw-us.apache.org) with ESMTPS id 81F3C60CE6; Thu, 9 May 2019 18:36:11 +0000 (UTC) Received: from 49eafecc6558 (vitalstatistix.ics.uci.edu [128.195.52.38]) by adrian-monk-v3.ics.uci.edu (8.14.7/8.14.7) with ESMTP id x49IZV7K002310; Thu, 9 May 2019 11:35:32 -0700 Message-Id: <201905091835.x49IZV7K002310@adrian-monk-v3.ics.uci.edu> X-Gerrit-PatchSet: 2 Date: Thu, 9 May 2019 18:35:31 +0000 From: "Ali Alsuliman (Code Review)" CC: Jenkins , Till Westmann , Michael Blow , Dmitry Lychagin X-Gerrit-MessageType: comment Subject: Change in asterixdb[master]: [ASTERIXDB-2555][RT][COMP] Make hash join use logical comparison X-Gerrit-Change-Id: If1834967fdd913fdc76003f09636b2450d07cd5e X-Gerrit-Change-Number: 3387 X-Gerrit-ChangeURL: X-Gerrit-Commit: d1b2816cc22228553578637b30c60bc4e52e1758 In-Reply-To: References: X-Gerrit-Comment-Date: Thu, 9 May 2019 18:35:31 +0000 Reply-To: ali.al.solaiman@gmail.com, dmitry.lychagin@couchbase.com, jenkins@unhygienix.ics.uci.edu, notifications@asterixdb.incubator.apache.org, mblow@apache.org, tillw@apache.org MIME-Version: 1.0 Content-Transfer-Encoding: 8bit Content-Disposition: inline User-Agent: Gerrit/2.14.19 Content-Type: multipart/alternative; boundary="KUpAF7KuLNU="; charset=UTF-8 X-ICS-MailScanner-Information: Please send mail to helpdesk@ics.uci.edu or more information X-ICS-MailScanner-ID: x49IZV7K002310 X-ICS-MailScanner: Found to be clean X-ICS-MailScanner-SpamCheck: not spam, SpamAssassin (not cached, score=-1.876, required 5, ALL_TRUSTED -1.00, BAYES_00 -1.90, FSL_HELO_NON_FQDN_1 0.00, HTML_MESSAGE 0.00, MISSING_HEADERS 1.02, URIBL_BLOCKED 0.00) X-ICS-MailScanner-From: dev@asterixdb.apache.org --KUpAF7KuLNU= Content-Type: text/plain; charset=UTF-8 Content-Transfer-Encoding: quoted-printable Ali Alsuliman has posted comments on this change=2E ( https://asterix-gerri= t=2Eics=2Euci=2Eedu/3387 ) Change subject: [ASTERIXDB-2555][RT][COMP] Make= hash join use logical comparison =2E=2E=2E=2E=2E=2E=2E=2E=2E=2E=2E=2E=2E= =2E=2E=2E=2E=2E=2E=2E=2E=2E=2E=2E=2E=2E=2E=2E=2E=2E=2E=2E=2E=2E=2E=2E=2E=2E= =2E=2E=2E=2E=2E=2E=2E=2E=2E=2E=2E=2E=2E=2E=2E=2E=2E=2E=2E=2E=2E=2E=2E=2E=2E= =2E=2E=2E=2E=2E=2E=2E Patch Set 2: (2 comments) https://asterix-gerrit= =2Eics=2Euci=2Eedu/#/c/3387/2/asterixdb/asterix-app/src/test/resources/runt= imets/results/join/hash_join_record/hash_join_record=2E03=2Eadm File asteri= xdb/asterix-app/src/test/resources/runtimets/results/join/hash_join_record/= hash_join_record=2E03=2Eadm: https://asterix-gerrit=2Eics=2Euci=2Eedu/#/c/= 3387/2/asterixdb/asterix-app/src/test/resources/runtimets/results/join/hash= _join_record/hash_join_record=2E03=2Eadm@a16 PS2, Line 16: > why these rec= ords no longer join? "address" values seem to be the same on b it's because= of the "apt" field being null=2E Logical comparison will render the whole = comparison as null which will render the comparison as false=2E This is inn= er join=2E https://asterix-gerrit=2Eics=2Euci=2Eedu/#/c/3387/2/hyracks-fu= llstack/hyracks/hyracks-dataflow-std/src/main/java/org/apache/hyracks/dataf= low/std/util/JoinUtil=2Ejava File hyracks-fullstack/hyracks/hyracks-dataflo= w-std/src/main/java/org/apache/hyracks/dataflow/std/util/JoinUtil=2Ejava: = https://asterix-gerrit=2Eics=2Euci=2Eedu/#/c/3387/2/hyracks-fullstack/hyrac= ks/hyracks-dataflow-std/src/main/java/org/apache/hyracks/dataflow/std/util/= JoinUtil=2Ejava@36 PS2, Line 36: public String printPartitionInfo(BitSe= t spilledStatus, OptimizedHybridHashJoin=2ESIDE whichSide, int numOfPartiti= ons, > This method is specific to OptimizedHybridHashJoin, so why did we mo= ve into it's a debugging print which is not used in OptimizedHybridHashJoin= =2E Having it there in production code isn't suitable, I think=2E But I can= move it back if you see otherwise=2E If it's about the package, I can keep= this Util class in the same package as the hybrid join=2E Let me know=2E = -- To view, visit https://asterix-gerrit=2Eics=2Euci=2Eedu/3387 To unsub= scribe, visit https://asterix-gerrit=2Eics=2Euci=2Eedu/settings Gerrit-Pro= ject: asterixdb Gerrit-Branch: master Gerrit-MessageType: comment Gerrit-Ch= ange-Id: If1834967fdd913fdc76003f09636b2450d07cd5e Gerrit-Change-Number: 33= 87 Gerrit-PatchSet: 2 Gerrit-Owner: Ali Alsuliman Gerrit-Reviewer: Ali Alsuliman G= errit-Reviewer: Anon=2E E=2E Moose (1000171) Gerrit-Reviewer: Dmitry Lychag= in Gerrit-Reviewer: Jenkins Gerrit-Reviewer: Michael Blow Gerrit-Reviewer: Till Westmann Gerrit-Comment-= Date: Thu, 09 May 2019 18:35:31 +0000 Gerrit-HasComments: Yes --KUpAF7KuLNU= Content-Type: text/html; charset=UTF-8 Content-Transfer-Encoding: quoted-printable

Ali Alsuliman posted comments on this change=2E

<= a href=3D"https://asterix-gerrit=2Eics=2Euci=2Eedu/3387">View Change

Patch set 2:

(2 comments)

To view, visit change 3387=2E To unsubscribe, visit settings=2E

Gerrit-Pr= oject: asterixdb
Gerrit-Branch: master =
Gerrit-MessageType: comment
Gerrit-Change-Id: If1834967fdd913fdc76003f09636b24= 50d07cd5e
Gerrit-Change-Number: 3387
Gerrit-PatchSet: 2
Gerrit-Owner: Ali Alsuliman <ali=2Eal=2Esolaiman@gmail=2Ec= om>
Gerrit-Reviewer: Ali Alsuliman &= lt;ali=2Eal=2Esolaiman@gmail=2Ecom>
= Gerrit-Reviewer: Anon=2E E=2E Moose (1000171)
Gerrit-Reviewer: Dmitry Lychagin <dmitry=2Elychagin@couchbase=2Ec= om>
Gerrit-Reviewer: Jenkins <jen= kins@fulliautomatix=2Eics=2Euci=2Eedu>
Gerrit-Reviewer: Michael Blow <mblow@apache=2Eorg>
Gerrit-Reviewer: Till Westmann <tillw@apache=2Eorg&= gt;
Gerrit-Comment-Date: Thu, 09 May 20= 19 18:35:31 +0000
Gerrit-HasComments: Y= es
--KUpAF7KuLNU=--