asterixdb-notifications mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From "Ali Alsuliman (Code Review)" <...@asterixdb.apache.org>
Subject Change in asterixdb[master]: [ASTERIXDB-2555][RT][COMP] Make hash join use logical comparison
Date Thu, 09 May 2019 18:35:31 GMT
Ali Alsuliman has posted comments on this change. ( https://asterix-gerrit.ics.uci.edu/3387
)

Change subject: [ASTERIXDB-2555][RT][COMP] Make hash join use logical comparison
......................................................................


Patch Set 2:

(2 comments)

https://asterix-gerrit.ics.uci.edu/#/c/3387/2/asterixdb/asterix-app/src/test/resources/runtimets/results/join/hash_join_record/hash_join_record.03.adm
File asterixdb/asterix-app/src/test/resources/runtimets/results/join/hash_join_record/hash_join_record.03.adm:

https://asterix-gerrit.ics.uci.edu/#/c/3387/2/asterixdb/asterix-app/src/test/resources/runtimets/results/join/hash_join_record/hash_join_record.03.adm@a16
PS2, Line 16: 
> why these records no longer join? "address" values seem to be the same on b
it's because of the "apt" field being null. Logical comparison will render the whole comparison
as null which will render the comparison as false. This is inner join.


https://asterix-gerrit.ics.uci.edu/#/c/3387/2/hyracks-fullstack/hyracks/hyracks-dataflow-std/src/main/java/org/apache/hyracks/dataflow/std/util/JoinUtil.java
File hyracks-fullstack/hyracks/hyracks-dataflow-std/src/main/java/org/apache/hyracks/dataflow/std/util/JoinUtil.java:

https://asterix-gerrit.ics.uci.edu/#/c/3387/2/hyracks-fullstack/hyracks/hyracks-dataflow-std/src/main/java/org/apache/hyracks/dataflow/std/util/JoinUtil.java@36
PS2, Line 36:     public String printPartitionInfo(BitSet spilledStatus, OptimizedHybridHashJoin.SIDE
whichSide, int numOfPartitions,
> This method is specific to OptimizedHybridHashJoin, so why did we move into
it's a debugging print which is not used in OptimizedHybridHashJoin. Having it there in production
code isn't suitable, I think. But I can move it back if you see otherwise. If it's about the
package, I can keep this Util class in the same package as the hybrid join. Let me know.



-- 
To view, visit https://asterix-gerrit.ics.uci.edu/3387
To unsubscribe, visit https://asterix-gerrit.ics.uci.edu/settings

Gerrit-Project: asterixdb
Gerrit-Branch: master
Gerrit-MessageType: comment
Gerrit-Change-Id: If1834967fdd913fdc76003f09636b2450d07cd5e
Gerrit-Change-Number: 3387
Gerrit-PatchSet: 2
Gerrit-Owner: Ali Alsuliman <ali.al.solaiman@gmail.com>
Gerrit-Reviewer: Ali Alsuliman <ali.al.solaiman@gmail.com>
Gerrit-Reviewer: Anon. E. Moose (1000171)
Gerrit-Reviewer: Dmitry Lychagin <dmitry.lychagin@couchbase.com>
Gerrit-Reviewer: Jenkins <jenkins@fulliautomatix.ics.uci.edu>
Gerrit-Reviewer: Michael Blow <mblow@apache.org>
Gerrit-Reviewer: Till Westmann <tillw@apache.org>
Gerrit-Comment-Date: Thu, 09 May 2019 18:35:31 +0000
Gerrit-HasComments: Yes

Mime
View raw message