asterixdb-notifications mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From "Till Westmann (Code Review)" <do-not-re...@asterixdb.incubator.apache.org>
Subject Change in asterixdb[master]: [NO ISSUE][ING] Refactor Active Suspend/Resume Logic
Date Fri, 26 Oct 2018 23:05:01 GMT
Till Westmann has posted comments on this change.

Change subject: [NO ISSUE][ING] Refactor Active Suspend/Resume Logic
......................................................................


Patch Set 2:

(5 comments)

https://asterix-gerrit.ics.uci.edu/#/c/2999/2/asterixdb/asterix-app/src/main/java/org/apache/asterix/app/active/ActiveNotificationHandler.java
File asterixdb/asterix-app/src/main/java/org/apache/asterix/app/active/ActiveNotificationHandler.java:

PS2, Line 258: LOGGER
pull the logging out (as below)?


PS2, Line 261: registeredListeners
inline (as below)?


PS2, Line 289: dataverseName + '.' + entityName
Just a question: Could we just use the toString of the EntityId here?


https://asterix-gerrit.ics.uci.edu/#/c/2999/1/asterixdb/asterix-app/src/main/java/org/apache/asterix/app/translator/QueryTranslator.java
File asterixdb/asterix-app/src/main/java/org/apache/asterix/app/translator/QueryTranslator.java:

PS1, Line 728: validateIfResourceIsActiveInFeed
> a) I put it back. However, I feel like this should be a runtime data except
a) Metadata operations are always tricky. As they happen during the compilation phase of a
request a CompilationException doesn't seem to be inadequate - at least at the outermost level.
In other cases where we execute something during compilation (e.g. during constant folding)
we'll execute, get a runtime exception ,and have the compiler report is as a compilation exception.


PS1, Line 2966: validateDatasetSta
> Where I come from, callBeforeXHook is called beforeX :)
I understand the original naming scheme, but I think that the current name is easier to grasp
on first contact.


-- 
To view, visit https://asterix-gerrit.ics.uci.edu/2999
To unsubscribe, visit https://asterix-gerrit.ics.uci.edu/settings

Gerrit-MessageType: comment
Gerrit-Change-Id: I38254582e08d97951a949f7327c8c3d7cf2ab51d
Gerrit-PatchSet: 2
Gerrit-Project: asterixdb
Gerrit-Branch: master
Gerrit-Owner: Murtadha Hubail <mhubail@apache.org>
Gerrit-Reviewer: Anon. E. Moose #1000171
Gerrit-Reviewer: Jenkins <jenkins@fulliautomatix.ics.uci.edu>
Gerrit-Reviewer: Murtadha Hubail <mhubail@apache.org>
Gerrit-Reviewer: Till Westmann <tillw@apache.org>
Gerrit-HasComments: Yes

Mime
View raw message