asterixdb-notifications mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From "Dmitry Lychagin (Code Review)" <do-not-re...@asterixdb.incubator.apache.org>
Subject Change in asterixdb[master]: [ASTERIXDB-2459][FUN] Add sttdev_pop() aggregate function
Date Fri, 19 Oct 2018 20:02:08 GMT
Dmitry Lychagin has posted comments on this change.

Change subject: [ASTERIXDB-2459][FUN] Add sttdev_pop() aggregate function
......................................................................


Patch Set 6:

(1 comment)

https://asterix-gerrit.ics.uci.edu/#/c/2997/6/asterixdb/asterix-runtime/src/main/java/org/apache/asterix/runtime/aggregates/std/StddevPopAggregateFunction.java
File asterixdb/asterix-runtime/src/main/java/org/apache/asterix/runtime/aggregates/std/StddevPopAggregateFunction.java:

Line 32: public class StddevPopAggregateFunction extends AbstractSingleVarStatisticsAggregateFunction
{
There are only 2 code differences between this class and StddevAggregateFunction: 1) the value
of 'delta': 0 vs 1; 2) function identifier (STDDEV vs STDDEV_POP).  As I was suggesting previously
let's just keep a single evaluator class StddevAggregateFunction but parameterize it with
2 constructor parameters: delta and funcId. We'll eliminate this class (StddevPopAggregateFunction)
and keep 2 descriptor classes: StddevAggregateDescritptor will create StddevAggregateFunction
evaluator instance with parameters delta=1, funcId=STDDEV, and StddevPopAggregateDescritptor
will create StddevAggregateFunction evaluator instance  with parameters delta=0, funcId=STDDEV_POP.
This way all "*StddevPopAggregateFunction" classes can be eliminated from this change because
their descriptors will create "*StddevAggregateFunction" evaluators with delta=0.


-- 
To view, visit https://asterix-gerrit.ics.uci.edu/2997
To unsubscribe, visit https://asterix-gerrit.ics.uci.edu/settings

Gerrit-MessageType: comment
Gerrit-Change-Id: I1732d8d70eba26e12a6e68d0e0c621491ed6b3ae
Gerrit-PatchSet: 6
Gerrit-Project: asterixdb
Gerrit-Branch: master
Gerrit-Owner: James Fang <jfang003@ucr.edu>
Gerrit-Reviewer: Anon. E. Moose #1000171
Gerrit-Reviewer: Dmitry Lychagin <dmitry.lychagin@couchbase.com>
Gerrit-Reviewer: James Fang <jfang003@ucr.edu>
Gerrit-Reviewer: Jenkins <jenkins@fulliautomatix.ics.uci.edu>
Gerrit-HasComments: Yes

Mime
View raw message