asterixdb-notifications mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From "Xikui Wang (Code Review)" <do-not-re...@asterixdb.incubator.apache.org>
Subject Change in asterixdb[master]: [NO ISSUE][COMP] Prevent broadcast hint changes left-outer-j...
Date Thu, 21 Jun 2018 23:18:35 GMT
Hello Anon. E. Moose #1000171, Jenkins,

I'd like you to reexamine a change.  Please visit

    https://asterix-gerrit.ics.uci.edu/2721

to look at the new patch set (#3).

Change subject: [NO ISSUE][COMP] Prevent broadcast hint changes left-outer-join semantic
......................................................................

[NO ISSUE][COMP] Prevent broadcast hint changes left-outer-join semantic

- user model changes: no
- storage format changes: no
- interface changes: no

Details:
The current way of handling broadcast hint can cause a problem in a
certain case. When we have a subquery containing join, the inline
subplan rule will transform it into a left-outer-join. If the join in
the subquery has a broadcast hint and the broadcast side is left, then
the JoinUtils will switch the two branches blindly which can break the
semantic of the left-outer-join.

Change-Id: I522b5f1edf35a1c46f2e2ef1b265049d3c18a575
---
A asterixdb/asterix-app/src/test/resources/optimizerts/queries/joins/nested_query_with_bcast.sqlpp
A asterixdb/asterix-app/src/test/resources/optimizerts/results/joins/nested_query_with_bcast.plan
M hyracks-fullstack/algebricks/algebricks-rewriter/src/main/java/org/apache/hyracks/algebricks/rewriter/util/JoinUtils.java
3 files changed, 92 insertions(+), 7 deletions(-)


  git pull ssh://asterix-gerrit.ics.uci.edu:29418/asterixdb refs/changes/21/2721/3
-- 
To view, visit https://asterix-gerrit.ics.uci.edu/2721
To unsubscribe, visit https://asterix-gerrit.ics.uci.edu/settings

Gerrit-MessageType: newpatchset
Gerrit-Change-Id: I522b5f1edf35a1c46f2e2ef1b265049d3c18a575
Gerrit-PatchSet: 3
Gerrit-Project: asterixdb
Gerrit-Branch: master
Gerrit-Owner: Xikui Wang <xkkwww@gmail.com>
Gerrit-Reviewer: Anon. E. Moose #1000171
Gerrit-Reviewer: Dmitry Lychagin <dmitry.lychagin@couchbase.com>
Gerrit-Reviewer: Jenkins <jenkins@fulliautomatix.ics.uci.edu>

Mime
View raw message