asterixdb-notifications mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From "Luo Chen (Code Review)" <do-not-re...@asterixdb.incubator.apache.org>
Subject Change in asterixdb[master]: [ASTERIXDB-2357] ADMParser Improvements
Date Fri, 06 Apr 2018 16:25:47 GMT
Hello Anon. E. Moose #1000171, Jenkins,

I'd like you to reexamine a change.  Please visit

    https://asterix-gerrit.ics.uci.edu/2573

to look at the new patch set (#4).

Change subject: [ASTERIXDB-2357] ADMParser Improvements
......................................................................

[ASTERIXDB-2357] ADMParser Improvements

- user model changes: no
- storage format changes: no
- interface changes: no

Details:
- The current ADMParser heavily relies on string operations,
which results in a lot of objects being created. This patch optimize
this by directly operating on char[].
- Improved exception handling in ADMParser.

Change-Id: I106b58e79746b0a6f3d8b79473202653341a7009
---
M asterixdb/asterix-common/src/main/resources/asx_errormsg/en.properties
M asterixdb/asterix-external-data/src/main/java/org/apache/asterix/external/parser/ADMDataParser.java
M asterixdb/asterix-external-data/src/main/java/org/apache/asterix/external/parser/AbstractDataParser.java
M asterixdb/asterix-external-data/src/main/java/org/apache/asterix/external/parser/JSONDataParser.java
A asterixdb/asterix-external-data/src/main/java/org/apache/asterix/external/parser/ParseException.java
M asterixdb/asterix-external-data/src/test/java/org/apache/asterix/external/parser/test/ADMDataParserTest.java
M asterixdb/asterix-maven-plugins/lexer-generator-maven-plugin/src/main/resources/Lexer.java
M asterixdb/asterix-om/src/main/java/org/apache/asterix/builders/RecordBuilder.java
M asterixdb/asterix-om/src/main/java/org/apache/asterix/dataflow/data/nontagged/serde/AStringSerializerDeserializer.java
M asterixdb/asterix-om/src/main/java/org/apache/asterix/om/base/AMutableUUID.java
M asterixdb/asterix-om/src/main/java/org/apache/asterix/om/base/temporal/ATimeParserFactory.java
M hyracks-fullstack/hyracks/hyracks-util/src/main/java/org/apache/hyracks/util/string/UTF8StringUtil.java
12 files changed, 452 insertions(+), 214 deletions(-)


  git pull ssh://asterix-gerrit.ics.uci.edu:29418/asterixdb refs/changes/73/2573/4
-- 
To view, visit https://asterix-gerrit.ics.uci.edu/2573
To unsubscribe, visit https://asterix-gerrit.ics.uci.edu/settings

Gerrit-MessageType: newpatchset
Gerrit-Change-Id: I106b58e79746b0a6f3d8b79473202653341a7009
Gerrit-PatchSet: 4
Gerrit-Project: asterixdb
Gerrit-Branch: master
Gerrit-Owner: Luo Chen <cluo8@uci.edu>
Gerrit-Reviewer: Anon. E. Moose #1000171
Gerrit-Reviewer: Jenkins <jenkins@fulliautomatix.ics.uci.edu>

Mime
View raw message