From notifications-return-88609-archive-asf-public=cust-asf.ponee.io@asterixdb.apache.org Thu Mar 1 05:35:04 2018 Return-Path: X-Original-To: archive-asf-public@cust-asf.ponee.io Delivered-To: archive-asf-public@cust-asf.ponee.io Received: from mail.apache.org (hermes.apache.org [140.211.11.3]) by mx-eu-01.ponee.io (Postfix) with SMTP id 33FBB180657 for ; Thu, 1 Mar 2018 05:35:04 +0100 (CET) Received: (qmail 50090 invoked by uid 500); 1 Mar 2018 04:35:03 -0000 Mailing-List: contact notifications-help@asterixdb.apache.org; run by ezmlm Precedence: bulk List-Help: List-Unsubscribe: List-Post: List-Id: Reply-To: dev@asterixdb.apache.org Delivered-To: mailing list notifications@asterixdb.apache.org Received: (qmail 50081 invoked by uid 99); 1 Mar 2018 04:35:02 -0000 Received: from pnap-us-west-generic-nat.apache.org (HELO spamd4-us-west.apache.org) (209.188.14.142) by apache.org (qpsmtpd/0.29) with ESMTP; Thu, 01 Mar 2018 04:35:02 +0000 Received: from localhost (localhost [127.0.0.1]) by spamd4-us-west.apache.org (ASF Mail Server at spamd4-us-west.apache.org) with ESMTP id 75EFEC0351 for ; Thu, 1 Mar 2018 04:35:02 +0000 (UTC) X-Virus-Scanned: Debian amavisd-new at spamd4-us-west.apache.org X-Spam-Flag: NO X-Spam-Score: -109.511 X-Spam-Level: X-Spam-Status: No, score=-109.511 tagged_above=-999 required=6.31 tests=[ENV_AND_HDR_SPF_MATCH=-0.5, KAM_ASCII_DIVIDERS=0.8, RCVD_IN_DNSWL_MED=-2.3, SPF_PASS=-0.001, T_RP_MATCHES_RCVD=-0.01, USER_IN_DEF_SPF_WL=-7.5, USER_IN_WHITELIST=-100] autolearn=disabled Received: from mx1-lw-us.apache.org ([10.40.0.8]) by localhost (spamd4-us-west.apache.org [10.40.0.11]) (amavisd-new, port 10024) with ESMTP id PPRooI_QJhmy for ; Thu, 1 Mar 2018 04:35:01 +0000 (UTC) Received: from mailrelay1-us-west.apache.org (mailrelay1-us-west.apache.org [209.188.14.139]) by mx1-lw-us.apache.org (ASF Mail Server at mx1-lw-us.apache.org) with ESMTP id 5854E5F126 for ; Thu, 1 Mar 2018 04:35:01 +0000 (UTC) Received: from jira-lw-us.apache.org (unknown [207.244.88.139]) by mailrelay1-us-west.apache.org (ASF Mail Server at mailrelay1-us-west.apache.org) with ESMTP id C87DAE015E for ; Thu, 1 Mar 2018 04:35:00 +0000 (UTC) Received: from jira-lw-us.apache.org (localhost [127.0.0.1]) by jira-lw-us.apache.org (ASF Mail Server at jira-lw-us.apache.org) with ESMTP id 7549B2412A for ; Thu, 1 Mar 2018 04:35:00 +0000 (UTC) Date: Thu, 1 Mar 2018 04:35:00 +0000 (UTC) From: "ASF subversion and git services (JIRA)" To: notifications@asterixdb.incubator.apache.org Message-ID: In-Reply-To: References: Subject: [jira] [Commented] (ASTERIXDB-2301) Abort of DELETE operation is not handled properly MIME-Version: 1.0 Content-Type: text/plain; charset=utf-8 Content-Transfer-Encoding: 7bit X-JIRA-FingerPrint: 30527f35849b9dde25b450d4833f0394 [ https://issues.apache.org/jira/browse/ASTERIXDB-2301?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16381499#comment-16381499 ] ASF subversion and git services commented on ASTERIXDB-2301: ------------------------------------------------------------ Commit 38baf98605a50ca7edc37cff554d6006a8891680 in asterixdb's branch refs/heads/master from [~luochen01] [ https://git-wip-us.apache.org/repos/asf?p=asterixdb.git;h=38baf98 ] [ASTERIXDB-2301][TX] Fix Abort of DELETE operation - user model changes: no - storage format changes: no - interface changes: no Details: - Fix the undo logic of the DELETE operation. Previously undo of DELETE is implemented as re-inserting the old value. However, if the deleted record is from the disk component, the old value could be null. In this case, we simply need to physically deleted the anti-matter key from the memory component, exactly the same as undo upsert. - Add test cases for undo. Change-Id: I5002d639399f024be8837da1c539101e6d62a159 Reviewed-on: https://asterix-gerrit.ics.uci.edu/2432 Sonar-Qube: Jenkins Reviewed-by: Michael Blow Tested-by: Jenkins Contrib: Jenkins Integration-Tests: Jenkins > Abort of DELETE operation is not handled properly > ------------------------------------------------- > > Key: ASTERIXDB-2301 > URL: https://issues.apache.org/jira/browse/ASTERIXDB-2301 > Project: Apache AsterixDB > Issue Type: Bug > Components: TX - Transactions > Reporter: Chen Luo > Assignee: Chen Luo > Priority: Critical > > The current abort of DELETE operation is simply re-inserting the old value. However, the old value is logged only when the deleted record was found in the memory component. If we delete a record which sits on the disk component, then old value is NULL and the abort of the delete record is not handled correctly. -- This message was sent by Atlassian JIRA (v7.6.3#76005)