From notifications-return-85773-archive-asf-public=cust-asf.ponee.io@asterixdb.apache.org Mon Feb 19 01:28:55 2018 Return-Path: X-Original-To: archive-asf-public@cust-asf.ponee.io Delivered-To: archive-asf-public@cust-asf.ponee.io Received: from mail.apache.org (hermes.apache.org [140.211.11.3]) by mx-eu-01.ponee.io (Postfix) with SMTP id EFB7118064D for ; Mon, 19 Feb 2018 01:28:54 +0100 (CET) Received: (qmail 67639 invoked by uid 500); 19 Feb 2018 00:28:54 -0000 Mailing-List: contact notifications-help@asterixdb.apache.org; run by ezmlm Precedence: bulk List-Help: List-Unsubscribe: List-Post: List-Id: Reply-To: dev@asterixdb.apache.org Delivered-To: mailing list notifications@asterixdb.apache.org Received: (qmail 67630 invoked by uid 99); 19 Feb 2018 00:28:54 -0000 Received: from pnap-us-west-generic-nat.apache.org (HELO spamd4-us-west.apache.org) (209.188.14.142) by apache.org (qpsmtpd/0.29) with ESMTP; Mon, 19 Feb 2018 00:28:54 +0000 Received: from localhost (localhost [127.0.0.1]) by spamd4-us-west.apache.org (ASF Mail Server at spamd4-us-west.apache.org) with ESMTP id AA2D5C0157 for ; Mon, 19 Feb 2018 00:28:53 +0000 (UTC) X-Virus-Scanned: Debian amavisd-new at spamd4-us-west.apache.org X-Spam-Flag: NO X-Spam-Score: 2.126 X-Spam-Level: ** X-Spam-Status: No, score=2.126 tagged_above=-999 required=6.31 tests=[MISSING_HEADERS=1.207, SPF_FAIL=0.919] autolearn=disabled Received: from mx1-lw-us.apache.org ([10.40.0.8]) by localhost (spamd4-us-west.apache.org [10.40.0.11]) (amavisd-new, port 10024) with ESMTP id DV9aGz-s1L2V for ; Mon, 19 Feb 2018 00:28:53 +0000 (UTC) Received: from vitalstatistix.ics.uci.edu (vitalstatistix.ics.uci.edu [128.195.52.38]) by mx1-lw-us.apache.org (ASF Mail Server at mx1-lw-us.apache.org) with ESMTP id AEB645F5DB for ; Mon, 19 Feb 2018 00:28:52 +0000 (UTC) Received: from localhost (localhost [127.0.0.1]) by vitalstatistix.ics.uci.edu (Postfix) with ESMTP id 51D19100746; Sun, 18 Feb 2018 16:28:52 -0800 (PST) Date: Sun, 18 Feb 2018 16:28:52 -0800 From: "abdullah alamoudi (Code Review)" CC: Jenkins , Michael Blow , Till Westmann Reply-To: bamousaa@gmail.com X-Gerrit-MessageType: comment Subject: Change in asterixdb[master]: [NO ISSUE][CLUS] Synchronize restoration of IPC connection X-Gerrit-Change-Id: I1ec58d7fbc96d7352882e6588ef2ce12dc66511e X-Gerrit-ChangeURL: X-Gerrit-Commit: 01275996c29ec60dd238982bef733b60236e08bd In-Reply-To: References: MIME-Version: 1.0 Content-Type: text/plain; charset=UTF-8 Content-Transfer-Encoding: 8bit Content-Disposition: inline User-Agent: Gerrit/2.12.7 Message-Id: <20180219002852.51D19100746@vitalstatistix.ics.uci.edu> abdullah alamoudi has posted comments on this change. Change subject: [NO ISSUE][CLUS] Synchronize restoration of IPC connection ...................................................................... Patch Set 2: (1 comment) https://asterix-gerrit.ics.uci.edu/#/c/2397/2/hyracks-fullstack/hyracks/hyracks-ipc/src/main/java/org/apache/hyracks/ipc/impl/ReconnectingIPCHandle.java File hyracks-fullstack/hyracks/hyracks-ipc/src/main/java/org/apache/hyracks/ipc/impl/ReconnectingIPCHandle.java: PS2, Line 75: synchronized > Do we think that this is so highly contested that making the method synchro This conflicts with Mike Blow's comment. Let me know which direction to take :) -- To view, visit https://asterix-gerrit.ics.uci.edu/2397 To unsubscribe, visit https://asterix-gerrit.ics.uci.edu/settings Gerrit-MessageType: comment Gerrit-Change-Id: I1ec58d7fbc96d7352882e6588ef2ce12dc66511e Gerrit-PatchSet: 2 Gerrit-Project: asterixdb Gerrit-Branch: master Gerrit-Owner: abdullah alamoudi Gerrit-Reviewer: Anon. E. Moose #1000171 Gerrit-Reviewer: Jenkins Gerrit-Reviewer: Michael Blow Gerrit-Reviewer: Till Westmann Gerrit-Reviewer: abdullah alamoudi Gerrit-HasComments: Yes