From notifications-return-84987-archive-asf-public=cust-asf.ponee.io@asterixdb.apache.org Wed Feb 14 22:51:33 2018 Return-Path: X-Original-To: archive-asf-public@cust-asf.ponee.io Delivered-To: archive-asf-public@cust-asf.ponee.io Received: from mail.apache.org (hermes.apache.org [140.211.11.3]) by mx-eu-01.ponee.io (Postfix) with SMTP id 187B7180621 for ; Wed, 14 Feb 2018 22:51:32 +0100 (CET) Received: (qmail 38052 invoked by uid 500); 14 Feb 2018 21:51:32 -0000 Mailing-List: contact notifications-help@asterixdb.apache.org; run by ezmlm Precedence: bulk List-Help: List-Unsubscribe: List-Post: List-Id: Reply-To: dev@asterixdb.apache.org Delivered-To: mailing list notifications@asterixdb.apache.org Received: (qmail 38043 invoked by uid 99); 14 Feb 2018 21:51:32 -0000 Received: from pnap-us-west-generic-nat.apache.org (HELO spamd2-us-west.apache.org) (209.188.14.142) by apache.org (qpsmtpd/0.29) with ESMTP; Wed, 14 Feb 2018 21:51:32 +0000 Received: from localhost (localhost [127.0.0.1]) by spamd2-us-west.apache.org (ASF Mail Server at spamd2-us-west.apache.org) with ESMTP id BFC561A04BB for ; Wed, 14 Feb 2018 21:51:31 +0000 (UTC) X-Virus-Scanned: Debian amavisd-new at spamd2-us-west.apache.org X-Spam-Flag: NO X-Spam-Score: 2.126 X-Spam-Level: ** X-Spam-Status: No, score=2.126 tagged_above=-999 required=6.31 tests=[MISSING_HEADERS=1.207, SPF_FAIL=0.919] autolearn=disabled Received: from mx1-lw-eu.apache.org ([10.40.0.8]) by localhost (spamd2-us-west.apache.org [10.40.0.9]) (amavisd-new, port 10024) with ESMTP id YSccrTbTycMd for ; Wed, 14 Feb 2018 21:51:31 +0000 (UTC) Received: from vitalstatistix.ics.uci.edu (vitalstatistix.ics.uci.edu [128.195.52.38]) by mx1-lw-eu.apache.org (ASF Mail Server at mx1-lw-eu.apache.org) with ESMTP id 5A5D65F180 for ; Wed, 14 Feb 2018 21:51:30 +0000 (UTC) Received: from localhost (localhost [127.0.0.1]) by vitalstatistix.ics.uci.edu (Postfix) with ESMTP id ADB241006CA; Wed, 14 Feb 2018 13:51:29 -0800 (PST) Date: Wed, 14 Feb 2018 13:51:29 -0800 From: "abdullah alamoudi (Code Review)" CC: Jenkins , Michael Blow Reply-To: bamousaa@gmail.com X-Gerrit-MessageType: comment Subject: Change in asterixdb[master]: [ASTERIXDB-2282][HTTP] Revive HTTP server on unexpected chan... X-Gerrit-Change-Id: I7da75a9e34795c94518aca243b4cef387221d8fd X-Gerrit-ChangeURL: X-Gerrit-Commit: 6ba16e2b39f50f2235b616c3a52170819a557370 In-Reply-To: References: MIME-Version: 1.0 Content-Type: text/plain; charset=UTF-8 Content-Transfer-Encoding: 8bit Content-Disposition: inline User-Agent: Gerrit/2.12.7 Message-Id: <20180214215129.ADB241006CA@vitalstatistix.ics.uci.edu> abdullah alamoudi has posted comments on this change. Change subject: [ASTERIXDB-2282][HTTP] Revive HTTP server on unexpected channel drops ...................................................................... Patch Set 7: (2 comments) https://asterix-gerrit.ics.uci.edu/#/c/2382/7/hyracks-fullstack/hyracks/hyracks-http/src/main/java/org/apache/hyracks/http/server/HttpServer.java File hyracks-fullstack/hyracks/hyracks-http/src/main/java/org/apache/hyracks/http/server/HttpServer.java: PS7, Line 266: true > ok, I see that this will exit on interrupt since we always set state to STO Done PS7, Line 385: new StringBuilder().append('{').append("\"class\"").append(':').append('\"') : .append(getClass().getSimpleName()).append('\"').append(',').append("\"port\"").append(':') : .append(Integer.toString(port)).append(',').append("\"state\"").append(':').append('\"').append(state) : .append('\"').append('}').toString() > this should be replaced with String concatenation- way more readable and th Done -- To view, visit https://asterix-gerrit.ics.uci.edu/2382 To unsubscribe, visit https://asterix-gerrit.ics.uci.edu/settings Gerrit-MessageType: comment Gerrit-Change-Id: I7da75a9e34795c94518aca243b4cef387221d8fd Gerrit-PatchSet: 7 Gerrit-Project: asterixdb Gerrit-Branch: master Gerrit-Owner: abdullah alamoudi Gerrit-Reviewer: Anon. E. Moose #1000171 Gerrit-Reviewer: Jenkins Gerrit-Reviewer: Michael Blow Gerrit-Reviewer: abdullah alamoudi Gerrit-HasComments: Yes