From notifications-return-82076-archive-asf-public=cust-asf.ponee.io@asterixdb.apache.org Sat Feb 3 02:16:46 2018 Return-Path: X-Original-To: archive-asf-public@eu.ponee.io Delivered-To: archive-asf-public@eu.ponee.io Received: from cust-asf.ponee.io (cust-asf.ponee.io [163.172.22.183]) by mx-eu-01.ponee.io (Postfix) with ESMTP id A0B5E180608 for ; Sat, 3 Feb 2018 02:16:46 +0100 (CET) Received: by cust-asf.ponee.io (Postfix) id 90588160C57; Sat, 3 Feb 2018 01:16:46 +0000 (UTC) Delivered-To: archive-asf-public@cust-asf.ponee.io Received: from mail.apache.org (hermes.apache.org [140.211.11.3]) by cust-asf.ponee.io (Postfix) with SMTP id D71AB160C49 for ; Sat, 3 Feb 2018 02:16:45 +0100 (CET) Received: (qmail 90471 invoked by uid 500); 3 Feb 2018 01:16:45 -0000 Mailing-List: contact notifications-help@asterixdb.apache.org; run by ezmlm Precedence: bulk List-Help: List-Unsubscribe: List-Post: List-Id: Reply-To: dev@asterixdb.apache.org Delivered-To: mailing list notifications@asterixdb.apache.org Received: (qmail 90461 invoked by uid 99); 3 Feb 2018 01:16:45 -0000 Received: from pnap-us-west-generic-nat.apache.org (HELO spamd4-us-west.apache.org) (209.188.14.142) by apache.org (qpsmtpd/0.29) with ESMTP; Sat, 03 Feb 2018 01:16:45 +0000 Received: from localhost (localhost [127.0.0.1]) by spamd4-us-west.apache.org (ASF Mail Server at spamd4-us-west.apache.org) with ESMTP id 85ECAC0452 for ; Sat, 3 Feb 2018 01:16:44 +0000 (UTC) X-Virus-Scanned: Debian amavisd-new at spamd4-us-west.apache.org X-Spam-Flag: NO X-Spam-Score: 0.919 X-Spam-Level: X-Spam-Status: No, score=0.919 tagged_above=-999 required=6.31 tests=[SPF_FAIL=0.919] autolearn=disabled Received: from mx1-lw-us.apache.org ([10.40.0.8]) by localhost (spamd4-us-west.apache.org [10.40.0.11]) (amavisd-new, port 10024) with ESMTP id 5TZFrW_cXon7 for ; Sat, 3 Feb 2018 01:16:43 +0000 (UTC) Received: from vitalstatistix.ics.uci.edu (vitalstatistix.ics.uci.edu [128.195.52.38]) by mx1-lw-us.apache.org (ASF Mail Server at mx1-lw-us.apache.org) with ESMTP id 4EA0C5F2A9 for ; Sat, 3 Feb 2018 01:16:43 +0000 (UTC) Received: from localhost (localhost [127.0.0.1]) by vitalstatistix.ics.uci.edu (Postfix) with ESMTP id F1E59100B5F; Fri, 2 Feb 2018 17:16:42 -0800 (PST) Date: Fri, 2 Feb 2018 17:16:42 -0800 From: "Ahmed Eldawy (Code Review)" To: Ahmed Eldawy CC: Ian Maxon , Xikui Wang , Jenkins Reply-To: aseldawy@gmail.com X-Gerrit-MessageType: comment Subject: Change in asterixdb[master]: [ASTERIXDB-1371][FUN][AQL][SQL] Add standard geometry data t... X-Gerrit-Change-Id: I9cddeffea42e85469b6fc38f361bd98e64025289 X-Gerrit-ChangeURL: X-Gerrit-Commit: 0c6380447ae09babedab81e28dce9782c691bee7 In-Reply-To: References: MIME-Version: 1.0 Content-Type: text/plain; charset=UTF-8 Content-Transfer-Encoding: 8bit Content-Disposition: inline User-Agent: Gerrit/2.12.7 Message-Id: <20180203011642.F1E59100B5F@vitalstatistix.ics.uci.edu> Ahmed Eldawy has posted comments on this change. Change subject: [ASTERIXDB-1371][FUN][AQL][SQL] Add standard geometry data type and functions ...................................................................... Patch Set 7: (3 comments) I didn't test its memory consumption but my understanding is that it will create as many Java objects as the number of records in the input. I understand how bad it is but this is the price of using the existing Esri library. It is not really optimized for streaming data from a binary stream where it reuses the same object over and over. I don't see anyway around it without changing the Esri library itself. However, we can probably have our own implementation for the easy functions (e.g., XMin and XMax) which does not create any objects and processes it from the binary stream. But we will still rely on Esri for the complex functions (e.g., Union and Intersect for multipolygon. > (4 comments) > > Has this been benchmarked for memory consumption? I see a lot of > places that look like to me, they will consume memory in proportion > to the data perhaps... https://asterix-gerrit.ics.uci.edu/#/c/2056/6/asterixdb/asterix-om/src/main/java/org/apache/asterix/dataflow/data/nontagged/serde/AGeometrySerializerDeserializer.java File asterixdb/asterix-om/src/main/java/org/apache/asterix/dataflow/data/nontagged/serde/AGeometrySerializerDeserializer.java: PS6, Line 49: OGCGeometry geometry = OGCGeometry.createFromOGCStructure( : OperatorImportFromWkb.local().executeOGC(0, buffer, null), SpatialReference.create(4326)); : return new AGeometry(geometry); > They should both be static final variables then, the numbers. Done https://asterix-gerrit.ics.uci.edu/#/c/2056/6/asterixdb/asterix-runtime/src/main/java/org/apache/asterix/runtime/aggregates/std/STUnionAggregateFunction.java File asterixdb/asterix-runtime/src/main/java/org/apache/asterix/runtime/aggregates/std/STUnionAggregateFunction.java: PS6, Line 66: : @ > That should definitely be a static final variable then. Done Line 104: } > Maybe use this UnsupportedItemTypeException? Done -- To view, visit https://asterix-gerrit.ics.uci.edu/2056 To unsubscribe, visit https://asterix-gerrit.ics.uci.edu/settings Gerrit-MessageType: comment Gerrit-Change-Id: I9cddeffea42e85469b6fc38f361bd98e64025289 Gerrit-PatchSet: 7 Gerrit-Project: asterixdb Gerrit-Branch: master Gerrit-Owner: Ahmed Eldawy Gerrit-Reviewer: Ahmed Eldawy Gerrit-Reviewer: Anon. E. Moose #1000171 Gerrit-Reviewer: Ian Maxon Gerrit-Reviewer: Jenkins Gerrit-Reviewer: Xikui Wang Gerrit-HasComments: Yes