asterixdb-notifications mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From "Murtadha Hubail (Code Review)" <do-not-re...@asterixdb.incubator.apache.org>
Subject Change in asterixdb[master]: [ASTERIXDB-1706][RT] Ensure All Result Frames Are Read
Date Tue, 30 Jan 2018 05:43:18 GMT
Hello Anon. E. Moose #1000171, Jenkins,

I'd like you to reexamine a change.  Please visit

    https://asterix-gerrit.ics.uci.edu/2337

to look at the new patch set (#3).

Change subject: [ASTERIXDB-1706][RT] Ensure All Result Frames Are Read
......................................................................

[ASTERIXDB-1706][RT] Ensure All Result Frames Are Read

- user model changes: no
- storage format changes: no
- interface changes: yes
  - Remoevd IDatasetInputChannelMonitor

Details:
- Currently there is a possibility that the EOS
  comes in DatasetInputChannelMonitor right after
  the check for avaibale frames is performed which
  will result in missing some result frames from
  being read. When this happens, empty result will
  be returned if no frames were read before. This
  change ensures that the state between checking
  the avaiable frames and the EOS is consistent.
- Clean up HyracksDatasetReader.
- Use error code for result read failure.

Change-Id: I7d5a78fa20fe200cfffd21a215e052481c6d61ca
---
M asterixdb/asterix-app/src/test/resources/runtimets/queries_sqlpp/async-deferred/AsyncDeferredQueries.xml
M hyracks-fullstack/hyracks/hyracks-api/src/main/java/org/apache/hyracks/api/dataset/DatasetDirectoryRecord.java
D hyracks-fullstack/hyracks/hyracks-api/src/main/java/org/apache/hyracks/api/dataset/IDatasetInputChannelMonitor.java
M hyracks-fullstack/hyracks/hyracks-api/src/main/java/org/apache/hyracks/api/exceptions/ErrorCode.java
M hyracks-fullstack/hyracks/hyracks-api/src/main/resources/errormsg/en.properties
M hyracks-fullstack/hyracks/hyracks-client/src/main/java/org/apache/hyracks/client/dataset/HyracksDatasetReader.java
6 files changed, 121 insertions(+), 176 deletions(-)


  git pull ssh://asterix-gerrit.ics.uci.edu:29418/asterixdb refs/changes/37/2337/3
-- 
To view, visit https://asterix-gerrit.ics.uci.edu/2337
To unsubscribe, visit https://asterix-gerrit.ics.uci.edu/settings

Gerrit-MessageType: newpatchset
Gerrit-Change-Id: I7d5a78fa20fe200cfffd21a215e052481c6d61ca
Gerrit-PatchSet: 3
Gerrit-Project: asterixdb
Gerrit-Branch: master
Gerrit-Owner: Murtadha Hubail <mhubail@apache.org>
Gerrit-Reviewer: Anon. E. Moose #1000171
Gerrit-Reviewer: Jenkins <jenkins@fulliautomatix.ics.uci.edu>
Gerrit-Reviewer: Till Westmann <tillw@apache.org>

Mime
View raw message