asterixdb-notifications mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From "Michael Blow (Code Review)" <do-not-re...@asterixdb.incubator.apache.org>
Subject Change in asterixdb[master]: [NO ISSUE] Log test output to info.log, other tweaks
Date Wed, 24 Jan 2018 06:07:27 GMT
Michael Blow has submitted this change and it was merged.

Change subject: [NO ISSUE] Log test output to info.log, other tweaks
......................................................................


[NO ISSUE] Log test output to info.log, other tweaks

Change-Id: Ib08ccd813d62ba547bbdd4b2c9fbd1325ad0a5bf
Reviewed-on: https://asterix-gerrit.ics.uci.edu/2314
Sonar-Qube: Jenkins <jenkins@fulliautomatix.ics.uci.edu>
Tested-by: Jenkins <jenkins@fulliautomatix.ics.uci.edu>
Integration-Tests: Jenkins <jenkins@fulliautomatix.ics.uci.edu>
Contrib: Jenkins <jenkins@fulliautomatix.ics.uci.edu>
Reviewed-by: Michael Blow <mblow@apache.org>
---
M asterixdb/asterix-app/src/main/resources/log4j2.xml
M asterixdb/asterix-app/src/test/java/org/apache/asterix/test/common/TestExecutor.java
M asterixdb/asterix-app/src/test/resources/log4j2-test.xml
M hyracks-fullstack/src/test/resources/log4j2-test.xml
4 files changed, 30 insertions(+), 17 deletions(-)

Approvals:
  Anon. E. Moose #1000171: 
  Jenkins: Verified; No violations found; ; Verified
  Michael Blow: Looks good to me, approved



diff --git a/asterixdb/asterix-app/src/main/resources/log4j2.xml b/asterixdb/asterix-app/src/main/resources/log4j2.xml
index 28c1a61..24bcf77 100644
--- a/asterixdb/asterix-app/src/main/resources/log4j2.xml
+++ b/asterixdb/asterix-app/src/main/resources/log4j2.xml
@@ -16,14 +16,14 @@
  ! specific language governing permissions and limitations
  ! under the License.
  !-->
-<Configuration status="INFO">
+<Configuration status="WARN">
   <Appenders>
-    <Console name="Console" target="SYSTEM_ERR">
+    <Console name="Console" target="SYSTEM_OUT">
       <PatternLayout pattern="%d{HH:mm:ss.SSS} [%t] %-5level %logger{36} - %msg%n"/>
     </Console>
   </Appenders>
   <Loggers>
-    <Root level="INFO">
+    <Root level="WARN">
       <AppenderRef ref="Console"/>
     </Root>
   </Loggers>
diff --git a/asterixdb/asterix-app/src/test/java/org/apache/asterix/test/common/TestExecutor.java
b/asterixdb/asterix-app/src/test/java/org/apache/asterix/test/common/TestExecutor.java
index c3c450c..4a3444e 100644
--- a/asterixdb/asterix-app/src/test/java/org/apache/asterix/test/common/TestExecutor.java
+++ b/asterixdb/asterix-app/src/test/java/org/apache/asterix/test/common/TestExecutor.java
@@ -1678,7 +1678,7 @@
             }
             if (!toBeDropped.isEmpty()) {
                 badtestcases.add(testCase);
-                LOGGER.warn("Last test left some garbage. Dropping dataverses: " + StringUtils.join(toBeDropped,
','));
+                LOGGER.info("Last test left some garbage. Dropping dataverses: " + StringUtils.join(toBeDropped,
','));
                 StringBuilder dropStatement = new StringBuilder();
                 for (String dv : toBeDropped) {
                     dropStatement.append("drop dataverse ");
diff --git a/asterixdb/asterix-app/src/test/resources/log4j2-test.xml b/asterixdb/asterix-app/src/test/resources/log4j2-test.xml
index 08eee10..2767ecb 100644
--- a/asterixdb/asterix-app/src/test/resources/log4j2-test.xml
+++ b/asterixdb/asterix-app/src/test/resources/log4j2-test.xml
@@ -18,20 +18,25 @@
  !-->
 <Configuration status="WARN">
   <Appenders>
-    <Console name="Console" target="SYSTEM_ERR">
+    <Console name="Console" target="SYSTEM_OUT">
       <PatternLayout pattern="%d{HH:mm:ss.SSS} [%t] %-5level %logger{36} - %msg%n"/>
     </Console>
+    <File name="InfoLog" fileName="target/info.log">
+        <PatternLayout pattern="%d{HH:mm:ss.SSS} [%t] %-5level %logger{36} - %msg%n"/>
+    </File>
   </Appenders>
   <Loggers>
-    <Root level="WARN"/>
+    <Root level="WARN">
+      <AppenderRef ref="InfoLog"/>
+    </Root>
+    <Logger name="org.apache.hyracks" level="INFO">
+      <AppenderRef ref="InfoLog"/>
+    </Logger>
+    <Logger name="org.apache.asterix" level="INFO">
+      <AppenderRef ref="InfoLog"/>
+    </Logger>
     <Logger name="org.apache.asterix.test" level="WARN">
       <AppenderRef ref="Console"/>
     </Logger>
-    <Logger name="org.apache.asterix.transaction.management.service.logging.LogFlusher"
level="INFO">
-      <AppenderRef ref="Console"/>
-    </Logger>
-    <Logger name="org.apache.asterix.utils.RebalanceUtil" level="INFO">
-      <AppenderRef ref="Console"/>
-    </Logger>
   </Loggers>
-</Configuration>
\ No newline at end of file
+</Configuration>
diff --git a/hyracks-fullstack/src/test/resources/log4j2-test.xml b/hyracks-fullstack/src/test/resources/log4j2-test.xml
index d42b935..b80111a 100644
--- a/hyracks-fullstack/src/test/resources/log4j2-test.xml
+++ b/hyracks-fullstack/src/test/resources/log4j2-test.xml
@@ -18,14 +18,22 @@
  !-->
 <Configuration status="WARN">
   <Appenders>
-    <Console name="Console" target="SYSTEM_ERR">
+    <Console name="Console" target="SYSTEM_OUT">
       <PatternLayout pattern="%d{HH:mm:ss.SSS} [%t] %-5level %logger{36} - %msg%n"/>
     </Console>
+    <File name="InfoLog" fileName="target/info.log">
+      <PatternLayout pattern="%d{HH:mm:ss.SSS} [%t] %-5level %logger{36} - %msg%n"/>
+    </File>
   </Appenders>
   <Loggers>
-    <Root level="WARN"/>
-    <Logger name="org.apache.hyracks" level="WARN">
+    <Root level="WARN">
+      <AppenderRef ref="InfoLog"/>
+    </Root>
+    <Logger name="org.apache.hyracks" level="INFO">
+      <AppenderRef ref="InfoLog"/>
+    </Logger>
+    <Logger name="org.apache.hyracks.test" level="WARN">
       <AppenderRef ref="Console"/>
     </Logger>
   </Loggers>
-</Configuration>
\ No newline at end of file
+</Configuration>

-- 
To view, visit https://asterix-gerrit.ics.uci.edu/2314
To unsubscribe, visit https://asterix-gerrit.ics.uci.edu/settings

Gerrit-MessageType: merged
Gerrit-Change-Id: Ib08ccd813d62ba547bbdd4b2c9fbd1325ad0a5bf
Gerrit-PatchSet: 4
Gerrit-Project: asterixdb
Gerrit-Branch: master
Gerrit-Owner: Ian Maxon <imaxon@apache.org>
Gerrit-Reviewer: Anon. E. Moose #1000171
Gerrit-Reviewer: Ian Maxon <imaxon@apache.org>
Gerrit-Reviewer: Jenkins <jenkins@fulliautomatix.ics.uci.edu>
Gerrit-Reviewer: Michael Blow <mblow@apache.org>

Mime
View raw message