asterixdb-notifications mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From "Ian Maxon (Code Review)" <do-not-re...@asterixdb.incubator.apache.org>
Subject Change in asterixdb[master]: [NO ISSUE][RT] Add test cases for runtime failures
Date Wed, 17 Jan 2018 02:14:46 GMT
Ian Maxon has posted comments on this change.

Change subject: [NO ISSUE][RT] Add test cases for runtime failures
......................................................................


Patch Set 2:

(2 comments)

i guess you could make all of them extend off of the NoOpOperatorDescriptor to reduce the
duplication a bit but im fine with it either way

https://asterix-gerrit.ics.uci.edu/#/c/2290/2/hyracks-fullstack/hyracks/hyracks-examples/hyracks-integration-tests/src/test/java/org/apache/hyracks/tests/util/FailOnInitializeDeInitializeOperatorDescriptor.java
File hyracks-fullstack/hyracks/hyracks-examples/hyracks-integration-tests/src/test/java/org/apache/hyracks/tests/util/FailOnInitializeDeInitializeOperatorDescriptor.java:

PS2, Line 31: lic class FailOnInitializeDeInitializeOperatorDescriptor extends AbstractSingleActivityOperatorDescriptor
{
error message isn't here but it's in the others


https://asterix-gerrit.ics.uci.edu/#/c/2290/2/hyracks-fullstack/hyracks/hyracks-examples/hyracks-integration-tests/src/test/java/org/apache/hyracks/tests/util/NoOpOperatorDescriptor.java
File hyracks-fullstack/hyracks/hyracks-examples/hyracks-integration-tests/src/test/java/org/apache/hyracks/tests/util/NoOpOperatorDescriptor.java:

PS2, Line 31: c class NoOpOperatorDescriptor extends AbstractSingleActivityOperatorDescriptor

ditto about the message field


-- 
To view, visit https://asterix-gerrit.ics.uci.edu/2290
To unsubscribe, visit https://asterix-gerrit.ics.uci.edu/settings

Gerrit-MessageType: comment
Gerrit-Change-Id: If26ade138b003349cfd9619188bd9129ecd1034a
Gerrit-PatchSet: 2
Gerrit-Project: asterixdb
Gerrit-Branch: master
Gerrit-Owner: abdullah alamoudi <bamousaa@gmail.com>
Gerrit-Reviewer: Anon. E. Moose #1000171
Gerrit-Reviewer: Ian Maxon <imaxon@apache.org>
Gerrit-Reviewer: Jenkins <jenkins@fulliautomatix.ics.uci.edu>
Gerrit-Reviewer: Michael Blow <mblow@apache.org>
Gerrit-Reviewer: Till Westmann <tillw@apache.org>
Gerrit-Reviewer: abdullah alamoudi <bamousaa@gmail.com>
Gerrit-HasComments: Yes

Mime
View raw message