asterixdb-notifications mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From "Steven Jacobs (Code Review)" <do-not-re...@asterixdb.incubator.apache.org>
Subject Change in asterixdb[master]: [ASTERIXDB-2199][COMP] Fix PushFieldAccessRule for nested pa...
Date Fri, 12 Jan 2018 18:23:41 GMT
Steven Jacobs has posted comments on this change.

Change subject: [ASTERIXDB-2199][COMP] Fix PushFieldAccessRule for nested partitioning keys
......................................................................


Patch Set 5:

(1 comment)

https://asterix-gerrit.ics.uci.edu/#/c/2246/5/asterixdb/asterix-metadata/src/main/java/org/apache/asterix/metadata/utils/DatasetUtil.java
File asterixdb/asterix-metadata/src/main/java/org/apache/asterix/metadata/utils/DatasetUtil.java:

PS5, Line 180: if (partitioningKey.size() != fieldExpr.size()) {
             :                 continue;
             :             }
             :             for (int j = 0; j < partitioningKey.size(); j++) {
             :                 if (!partitioningKey.get(j).equals(fieldExpr.get(j))) {
             :                     break;
             :                 }
             :                 if (j == partitioningKey.size() - 1) {
             :                     return i;
             :                 }
             :             }
> Doesn't partitioningKey.equals(fieldExpr) work?(https://stackoverflow.com/q
Done


-- 
To view, visit https://asterix-gerrit.ics.uci.edu/2246
To unsubscribe, visit https://asterix-gerrit.ics.uci.edu/settings

Gerrit-MessageType: comment
Gerrit-Change-Id: I874c1fd15719b6bdeb7b0913fbafc04a58d32ed4
Gerrit-PatchSet: 5
Gerrit-Project: asterixdb
Gerrit-Branch: master
Gerrit-Owner: Steven Jacobs <sjaco002@ucr.edu>
Gerrit-Reviewer: Anon. E. Moose #1000171
Gerrit-Reviewer: Dmitry Lychagin <dmitry.lychagin@couchbase.com>
Gerrit-Reviewer: Ildar Absalyamov <ildar.absalyamov@gmail.com>
Gerrit-Reviewer: Jenkins <jenkins@fulliautomatix.ics.uci.edu>
Gerrit-Reviewer: Shiva Jahangiri <shivaj@uci.edu>
Gerrit-Reviewer: Steven Jacobs <sjaco002@ucr.edu>
Gerrit-Reviewer: Till Westmann <tillw@apache.org>
Gerrit-HasComments: Yes

Mime
View raw message