asterixdb-notifications mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From "Murtadha Hubail (Code Review)" <do-not-re...@asterixdb.incubator.apache.org>
Subject Change in asterixdb[master]: [ASTERIXDB-2234][STO] Delete Invalid Components
Date Tue, 09 Jan 2018 21:06:46 GMT
Murtadha Hubail has posted comments on this change.

Change subject: [ASTERIXDB-2234][STO] Delete Invalid Components
......................................................................


Patch Set 2:

(2 comments)

https://asterix-gerrit.ics.uci.edu/#/c/2270/1/asterixdb/asterix-transactions/src/main/java/org/apache/asterix/transaction/management/resource/PersistentLocalResourceRepository.java
File asterixdb/asterix-transactions/src/main/java/org/apache/asterix/transaction/management/resource/PersistentLocalResourceRepository.java:

PS1, Line 406:  any components
> it seems inefficient to create one of these on each delete- can we put thes
Done


https://asterix-gerrit.ics.uci.edu/#/c/2270/1/hyracks-fullstack/hyracks/hyracks-storage-am-lsm-common/src/main/java/org/apache/hyracks/storage/am/lsm/common/impls/AbstractLSMIndexFileManager.java
File hyracks-fullstack/hyracks/hyracks-storage-am-lsm-common/src/main/java/org/apache/hyracks/storage/am/lsm/common/impls/AbstractLSMIndexFileManager.java:

PS1, Line 92: new SimpleDateFormat(COMPONENT_TIMESTAMP_FORMAT)
> can this be accessed concurrently?  sdf is not thread-safe and needs to be 
with the way we do things right now, I don't think so. Each index has it's own fileManager
object and we don't schedule flushes (i.e. the operation that uses this formatter to generate
component timestamp) concurrently.


-- 
To view, visit https://asterix-gerrit.ics.uci.edu/2270
To unsubscribe, visit https://asterix-gerrit.ics.uci.edu/settings

Gerrit-MessageType: comment
Gerrit-Change-Id: Ib11782edd79c7ef0c8949cb08e863b0ec1687a87
Gerrit-PatchSet: 2
Gerrit-Project: asterixdb
Gerrit-Branch: master
Gerrit-Owner: Murtadha Hubail <mhubail@apache.org>
Gerrit-Reviewer: Anon. E. Moose #1000171
Gerrit-Reviewer: Jenkins <jenkins@fulliautomatix.ics.uci.edu>
Gerrit-Reviewer: Michael Blow <mblow@apache.org>
Gerrit-Reviewer: Murtadha Hubail <mhubail@apache.org>
Gerrit-Reviewer: Till Westmann <tillw@apache.org>
Gerrit-Reviewer: abdullah alamoudi <bamousaa@gmail.com>
Gerrit-HasComments: Yes

Mime
View raw message