asterixdb-notifications mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From "abdullah alamoudi (Code Review)" <do-not-re...@asterixdb.incubator.apache.org>
Subject Change in asterixdb[master]: [ASTERIXDB-2182][ING] Use JSON-like syntax for feed configur...
Date Thu, 21 Dec 2017 05:40:12 GMT
abdullah alamoudi has posted comments on this change.

Change subject: [ASTERIXDB-2182][ING] Use JSON-like syntax for feed configuration
......................................................................


Patch Set 9:

(7 comments)

looks good.
we should do this for external data as well next.

https://asterix-gerrit.ics.uci.edu/#/c/2209/9/asterixdb/asterix-app/src/main/java/org/apache/asterix/app/function/FeedRewriter.java
File asterixdb/asterix-app/src/main/java/org/apache/asterix/app/function/FeedRewriter.java:

PS9, Line 126: getFeedConfiguration
it is a feed, so can we change to sourceFeed.getConfiguration()?


https://asterix-gerrit.ics.uci.edu/#/c/2209/9/asterixdb/asterix-app/src/main/java/org/apache/asterix/app/translator/QueryTranslator.java
File asterixdb/asterix-app/src/main/java/org/apache/asterix/app/translator/QueryTranslator.java:

PS9, Line 1934: Feed feed;
move down to 1936?
your call


https://asterix-gerrit.ics.uci.edu/#/c/2209/9/asterixdb/asterix-app/src/test/resources/runtimets/queries/external-library/typed_adapter/typed_adapter.3.ddl.aql
File asterixdb/asterix-app/src/test/resources/runtimets/queries/external-library/typed_adapter/typed_adapter.3.ddl.aql:

PS9, Line 31: testlib#test_typed_adapter
we can later separate the library into its own key


https://asterix-gerrit.ics.uci.edu/#/c/2209/9/asterixdb/asterix-external-data/src/main/java/org/apache/asterix/external/feed/api/IFeed.java
File asterixdb/asterix-external-data/src/main/java/org/apache/asterix/external/feed/api/IFeed.java:

PS9, Line 33: getFeedConfiguration
getConfiguration()


https://asterix-gerrit.ics.uci.edu/#/c/2209/9/asterixdb/asterix-lang-common/src/main/java/org/apache/asterix/lang/common/statement/CreateFeedStatement.java
File asterixdb/asterix-lang-common/src/main/java/org/apache/asterix/lang/common/statement/CreateFeedStatement.java:

PS9, Line 77: getFeedConfigurations
getConfiguration(). consistently use singular?


https://asterix-gerrit.ics.uci.edu/#/c/2209/9/asterixdb/asterix-lang-common/src/main/java/org/apache/asterix/lang/common/visitor/FormatPrintVisitor.java
File asterixdb/asterix-lang-common/src/main/java/org/apache/asterix/lang/common/visitor/FormatPrintVisitor.java:

Line 758:         printConfiguration(cfs.getFeedConfigurations());
we should fix this.
look at the print for the dataset decl, we make sure it is printed correctly as per the syntax?


https://asterix-gerrit.ics.uci.edu/#/c/2209/9/asterixdb/asterix-metadata/src/main/java/org/apache/asterix/metadata/feeds/FeedMetadataUtil.java
File asterixdb/asterix-metadata/src/main/java/org/apache/asterix/metadata/feeds/FeedMetadataUtil.java:

PS9, Line 110: if (adapterName == null) {
             :                 throw new AlgebricksException("cannot find adatper name");
             :             }
I wonder if the generic adapter can be chosen if this is not passed.
However, this is orthogonal to this change.


-- 
To view, visit https://asterix-gerrit.ics.uci.edu/2209
To unsubscribe, visit https://asterix-gerrit.ics.uci.edu/settings

Gerrit-MessageType: comment
Gerrit-Change-Id: I2dfb0fdf74d28ae0c45dafcf6babb624bd8b2149
Gerrit-PatchSet: 9
Gerrit-Project: asterixdb
Gerrit-Branch: master
Gerrit-Owner: Xikui Wang <xkkwww@gmail.com>
Gerrit-Reviewer: Anon. E. Moose #1000171
Gerrit-Reviewer: Jenkins <jenkins@fulliautomatix.ics.uci.edu>
Gerrit-Reviewer: abdullah alamoudi <bamousaa@gmail.com>
Gerrit-HasComments: Yes

Mime
View raw message