asterixdb-notifications mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From "abdullah alamoudi (Code Review)" <do-not-re...@asterixdb.incubator.apache.org>
Subject Change in asterixdb[master]: [NO ISSUE][TEST] Allow Diagnostic files to be run for failin...
Date Wed, 20 Dec 2017 05:42:51 GMT
abdullah alamoudi has posted comments on this change.

Change subject: [NO ISSUE][TEST] Allow Diagnostic files to be run for failing tests
......................................................................


Patch Set 17:

> Could we add a test that tests and demonstrates the feature?
 > (Especially if there's another revision on the change - otherwise
 > we could do that separately as well.)

This can be done but it is not a trivial change and it is not totally clear how to do this.

However, since this is the test framework and not the product,  I think it is not that critical.
we will know it is broken when we run a test case that fails with diagnostics and we don't
see the diagnostic output.

-- 
To view, visit https://asterix-gerrit.ics.uci.edu/2230
To unsubscribe, visit https://asterix-gerrit.ics.uci.edu/settings

Gerrit-MessageType: comment
Gerrit-Change-Id: I798726514cd46bcee04a8f290df54ae5bb4fb0a6
Gerrit-PatchSet: 17
Gerrit-Project: asterixdb
Gerrit-Branch: master
Gerrit-Owner: abdullah alamoudi <bamousaa@gmail.com>
Gerrit-Reviewer: Anon. E. Moose #1000171
Gerrit-Reviewer: Ian Maxon <imaxon@apache.org>
Gerrit-Reviewer: Jenkins <jenkins@fulliautomatix.ics.uci.edu>
Gerrit-Reviewer: Michael Blow <mblow@apache.org>
Gerrit-Reviewer: Murtadha Hubail <mhubail@apache.org>
Gerrit-Reviewer: Till Westmann <tillw@apache.org>
Gerrit-Reviewer: abdullah alamoudi <bamousaa@gmail.com>
Gerrit-HasComments: No

Mime
View raw message