asterixdb-notifications mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From "abdullah alamoudi (Code Review)" <do-not-re...@asterixdb.incubator.apache.org>
Subject Change in asterixdb[master]: [NO ISSUE][TEST] Allow Diagnostic files to be run for failin...
Date Sun, 17 Dec 2017 03:43:25 GMT
abdullah alamoudi has posted comments on this change.

Change subject: [NO ISSUE][TEST] Allow Diagnostic files to be run for failing tests
......................................................................


Patch Set 8:

(1 comment)

https://asterix-gerrit.ics.uci.edu/#/c/2230/8/asterixdb/asterix-test-framework/src/main/java/org/apache/asterix/testframework/context/TestFileContext.java
File asterixdb/asterix-test-framework/src/main/java/org/apache/asterix/testframework/context/TestFileContext.java:

Line 66:         } catch (Exception e) {
> at least there should be a comment here- but not sure I love that we're ove
It used to only allow numbers but I wanted to allow a string to have special diagnose files.
where in place of the sequence, I would put "diagnose". The problem with treating all as a
string is that in some cases there are more than 9 files in some test cases and those end
up having .10. which comes before .2.


-- 
To view, visit https://asterix-gerrit.ics.uci.edu/2230
To unsubscribe, visit https://asterix-gerrit.ics.uci.edu/settings

Gerrit-MessageType: comment
Gerrit-Change-Id: I798726514cd46bcee04a8f290df54ae5bb4fb0a6
Gerrit-PatchSet: 8
Gerrit-Project: asterixdb
Gerrit-Branch: master
Gerrit-Owner: abdullah alamoudi <bamousaa@gmail.com>
Gerrit-Reviewer: Anon. E. Moose #1000171
Gerrit-Reviewer: Ian Maxon <imaxon@apache.org>
Gerrit-Reviewer: Jenkins <jenkins@fulliautomatix.ics.uci.edu>
Gerrit-Reviewer: Michael Blow <mblow@apache.org>
Gerrit-Reviewer: Murtadha Hubail <mhubail@apache.org>
Gerrit-Reviewer: Till Westmann <tillw@apache.org>
Gerrit-Reviewer: abdullah alamoudi <bamousaa@gmail.com>
Gerrit-HasComments: Yes

Mime
View raw message