asterixdb-notifications mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From "abdullah alamoudi (Code Review)" <do-not-re...@asterixdb.incubator.apache.org>
Subject Change in asterixdb[master]: [ASTERIXDB-2194][COMP] Introduce datasource functions
Date Fri, 15 Dec 2017 16:30:46 GMT
abdullah alamoudi has posted comments on this change.

Change subject: [ASTERIXDB-2194][COMP] Introduce datasource functions
......................................................................


Patch Set 8:

(1 comment)

https://asterix-gerrit.ics.uci.edu/#/c/2216/8/asterixdb/asterix-om/src/main/java/org/apache/asterix/om/types/ARecordType.java
File asterixdb/asterix-om/src/main/java/org/apache/asterix/om/types/ARecordType.java:

Line 45:     public static final ARecordType ANY_OBJECT_RECORD_TYPE =
> We already have RecordUtil.FULLY_OPEN_RECORD_TYPE. Can we use it instead?
interesting... btw, I just moved this from https://asterix-gerrit.ics.uci.edu/#/c/2216/8/asterixdb/asterix-metadata/src/main/java/org/apache/asterix/metadata/bootstrap/MetadataBuiltinEntities.java


-- 
To view, visit https://asterix-gerrit.ics.uci.edu/2216
To unsubscribe, visit https://asterix-gerrit.ics.uci.edu/settings

Gerrit-MessageType: comment
Gerrit-Change-Id: Ibcf807ac713a21e8f4d59868525467386e801303
Gerrit-PatchSet: 8
Gerrit-Project: asterixdb
Gerrit-Branch: master
Gerrit-Owner: abdullah alamoudi <bamousaa@gmail.com>
Gerrit-Reviewer: Ali Alsuliman <ali.al.solaiman@gmail.com>
Gerrit-Reviewer: Anon. E. Moose #1000171
Gerrit-Reviewer: Dmitry Lychagin <dmitry.lychagin@couchbase.com>
Gerrit-Reviewer: Jenkins <jenkins@fulliautomatix.ics.uci.edu>
Gerrit-Reviewer: Till Westmann <tillw@apache.org>
Gerrit-Reviewer: abdullah alamoudi <bamousaa@gmail.com>
Gerrit-HasComments: Yes

Mime
View raw message