asterixdb-notifications mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From "Wail Alkowaileet (Code Review)" <do-not-re...@asterixdb.incubator.apache.org>
Subject Change in asterixdb[master]: [NO ISSUE] Jackson parser for JSON format
Date Thu, 07 Dec 2017 09:23:59 GMT
Wail Alkowaileet has posted comments on this change.

Change subject: [NO ISSUE] Jackson parser for JSON format
......................................................................


Patch Set 8:

(2 comments)

https://asterix-gerrit.ics.uci.edu/#/c/2076/7/asterixdb/asterix-external-data/src/main/java/org/apache/asterix/external/api/IDataParserFactory.java
File asterixdb/asterix-external-data/src/main/java/org/apache/asterix/external/api/IDataParserFactory.java:

PS7, Line 53:  @throws AsterixException
            :      *             if the parser does not support certain types defined in {@value
recordType}.
            :      */
> Can we instead have the factory create ADMParser in case the record type ne
I made the suggested change... However, there are two ideas fighting in my head. One is that
I want to keep the same previous logic (JSON = ADM). The other idea is compatible types (polygon/time...etc)
have different representation in ADM and JSON ?


https://asterix-gerrit.ics.uci.edu/#/c/2076/7/asterixdb/asterix-external-data/src/main/java/org/apache/asterix/external/parser/jackson/ObjectPool.java
File asterixdb/asterix-external-data/src/main/java/org/apache/asterix/external/parser/jackson/ObjectPool.java:

PS7, Line 41: 
> use ArrayDequeue? LinkedList<> will create a node object with each add call
Done


-- 
To view, visit https://asterix-gerrit.ics.uci.edu/2076
To unsubscribe, visit https://asterix-gerrit.ics.uci.edu/settings

Gerrit-MessageType: comment
Gerrit-Change-Id: Iacf9e496dbe2146f5eeeb1506b945991c300a7de
Gerrit-PatchSet: 8
Gerrit-Project: asterixdb
Gerrit-Branch: master
Gerrit-Owner: Wail Alkowaileet <wael.y.k@gmail.com>
Gerrit-Reviewer: Anon. E. Moose #1000171
Gerrit-Reviewer: Jenkins <jenkins@fulliautomatix.ics.uci.edu>
Gerrit-Reviewer: Till Westmann <tillw@apache.org>
Gerrit-Reviewer: Wail Alkowaileet <wael.y.k@gmail.com>
Gerrit-Reviewer: Xikui Wang <xkkwww@gmail.com>
Gerrit-Reviewer: abdullah alamoudi <bamousaa@gmail.com>
Gerrit-HasComments: Yes

Mime
View raw message