asterixdb-notifications mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From "Till Westmann (Code Review)" <do-not-re...@asterixdb.incubator.apache.org>
Subject Change in asterixdb[master]: [NO ISSUE][STO] Introduce Index Checkpoints
Date Thu, 07 Dec 2017 04:51:35 GMT
Till Westmann has posted comments on this change.

Change subject: [NO ISSUE][STO] Introduce Index Checkpoints
......................................................................


Patch Set 11:

(5 comments)

https://asterix-gerrit.ics.uci.edu/#/c/2200/11//COMMIT_MSG
Commit Message:

PS11, Line 10: no
I think there are storage changes.


https://asterix-gerrit.ics.uci.edu/#/c/2200/11/asterixdb/asterix-app/src/main/java/org/apache/asterix/app/nc/IndexCheckpointManager.java
File asterixdb/asterix-app/src/main/java/org/apache/asterix/app/nc/IndexCheckpointManager.java:

PS11, Line 147: IOException
This seems to lose the root exception.


PS11, Line 161: fromJson
Can this return null?


PS11, Line 165: IOException
Would it make sense to throw IOExceptions inside the class instead of logging here?


https://asterix-gerrit.ics.uci.edu/#/c/2200/11/asterixdb/asterix-transactions/src/main/java/org/apache/asterix/transaction/management/service/logging/LogBuffer.java
File asterixdb/asterix-transactions/src/main/java/org/apache/asterix/transaction/management/service/logging/LogBuffer.java:

PS11, Line 323: logRecord
Looks like we'll get an NPE here, if the thread is interrupted when waiting on the queue.


-- 
To view, visit https://asterix-gerrit.ics.uci.edu/2200
To unsubscribe, visit https://asterix-gerrit.ics.uci.edu/settings

Gerrit-MessageType: comment
Gerrit-Change-Id: Ib22800002bf8ea3660242e599b3f5f20678301a8
Gerrit-PatchSet: 11
Gerrit-Project: asterixdb
Gerrit-Branch: master
Gerrit-Owner: Murtadha Hubail <mhubail@apache.org>
Gerrit-Reviewer: Anon. E. Moose #1000171
Gerrit-Reviewer: Jenkins <jenkins@fulliautomatix.ics.uci.edu>
Gerrit-Reviewer: Michael Blow <mblow@apache.org>
Gerrit-Reviewer: Murtadha Hubail <mhubail@apache.org>
Gerrit-Reviewer: Till Westmann <tillw@apache.org>
Gerrit-Reviewer: abdullah alamoudi <bamousaa@gmail.com>
Gerrit-HasComments: Yes

Mime
View raw message