Return-Path: X-Original-To: archive-asf-public-internal@cust-asf2.ponee.io Delivered-To: archive-asf-public-internal@cust-asf2.ponee.io Received: from cust-asf.ponee.io (cust-asf.ponee.io [163.172.22.183]) by cust-asf2.ponee.io (Postfix) with ESMTP id 9AC80200D45 for ; Thu, 9 Nov 2017 02:57:11 +0100 (CET) Received: by cust-asf.ponee.io (Postfix) id 99262160C01; Thu, 9 Nov 2017 01:57:11 +0000 (UTC) Delivered-To: archive-asf-public@cust-asf.ponee.io Received: from mail.apache.org (hermes.apache.org [140.211.11.3]) by cust-asf.ponee.io (Postfix) with SMTP id E1202160BDA for ; Thu, 9 Nov 2017 02:57:10 +0100 (CET) Received: (qmail 8329 invoked by uid 500); 9 Nov 2017 01:57:10 -0000 Mailing-List: contact notifications-help@asterixdb.apache.org; run by ezmlm Precedence: bulk List-Help: List-Unsubscribe: List-Post: List-Id: Reply-To: dev@asterixdb.apache.org Delivered-To: mailing list notifications@asterixdb.apache.org Received: (qmail 8320 invoked by uid 99); 9 Nov 2017 01:57:10 -0000 Received: from pnap-us-west-generic-nat.apache.org (HELO spamd2-us-west.apache.org) (209.188.14.142) by apache.org (qpsmtpd/0.29) with ESMTP; Thu, 09 Nov 2017 01:57:10 +0000 Received: from localhost (localhost [127.0.0.1]) by spamd2-us-west.apache.org (ASF Mail Server at spamd2-us-west.apache.org) with ESMTP id 48C2E1A0736 for ; Thu, 9 Nov 2017 01:57:09 +0000 (UTC) X-Virus-Scanned: Debian amavisd-new at spamd2-us-west.apache.org X-Spam-Flag: NO X-Spam-Score: 4.073 X-Spam-Level: **** X-Spam-Status: No, score=4.073 tagged_above=-999 required=6.31 tests=[MISSING_HEADERS=1.207, REPLYTO_WITHOUT_TO_CC=1.946, SPF_FAIL=0.919, URIBL_BLOCKED=0.001] autolearn=disabled Received: from mx1-lw-us.apache.org ([10.40.0.8]) by localhost (spamd2-us-west.apache.org [10.40.0.9]) (amavisd-new, port 10024) with ESMTP id wLzQh3EI1rBD for ; Thu, 9 Nov 2017 01:57:08 +0000 (UTC) Received: from vitalstatistix.ics.uci.edu (vitalstatistix.ics.uci.edu [128.195.52.38]) by mx1-lw-us.apache.org (ASF Mail Server at mx1-lw-us.apache.org) with ESMTP id CD15460E83 for ; Thu, 9 Nov 2017 01:57:07 +0000 (UTC) Received: from localhost (localhost [127.0.0.1]) by vitalstatistix.ics.uci.edu (Postfix) with ESMTP id 803C0100A39; Wed, 8 Nov 2017 17:57:07 -0800 (PST) Date: Wed, 8 Nov 2017 17:57:07 -0800 From: "Michael Blow (Code Review)" Message-ID: Reply-To: mblow@apache.org X-Gerrit-MessageType: newchange Subject: Change in asterixdb[release-0.9.3-pre-rc]: [NO ISSUE][HYR] Heartbeat processing / NC exceptions X-Gerrit-Change-Id: If8fd35a7fd488bed5f1d5e2146dd48892cb0a7a4 X-Gerrit-ChangeURL: X-Gerrit-Commit: 3cc19da4daaf48494b0caf3b041f87b01ea9eea2 MIME-Version: 1.0 Content-Type: text/plain; charset=UTF-8 Content-Transfer-Encoding: 8bit Content-Disposition: inline User-Agent: Gerrit/2.12.7 archived-at: Thu, 09 Nov 2017 01:57:11 -0000 Michael Blow has uploaded a new change for review. https://asterix-gerrit.ics.uci.edu/2138 Change subject: [NO ISSUE][HYR] Heartbeat processing / NC exceptions ...................................................................... [NO ISSUE][HYR] Heartbeat processing / NC exceptions - Run heartbeat processing off of Worker thread, to prevent starvation - Preserve stacktrace when creating node-scoped HyracksDataException clones Change-Id: If8fd35a7fd488bed5f1d5e2146dd48892cb0a7a4 --- M hyracks-fullstack/hyracks/hyracks-api/src/main/java/org/apache/hyracks/api/exceptions/HyracksDataException.java M hyracks-fullstack/hyracks/hyracks-api/src/main/java/org/apache/hyracks/api/exceptions/HyracksException.java M hyracks-fullstack/hyracks/hyracks-control/hyracks-control-cc/src/main/java/org/apache/hyracks/control/cc/ClusterControllerIPCI.java 3 files changed, 5 insertions(+), 4 deletions(-) git pull ssh://asterix-gerrit.ics.uci.edu:29418/asterixdb refs/changes/38/2138/1 diff --git a/hyracks-fullstack/hyracks/hyracks-api/src/main/java/org/apache/hyracks/api/exceptions/HyracksDataException.java b/hyracks-fullstack/hyracks/hyracks-api/src/main/java/org/apache/hyracks/api/exceptions/HyracksDataException.java index 4517730..a480084 100644 --- a/hyracks-fullstack/hyracks/hyracks-api/src/main/java/org/apache/hyracks/api/exceptions/HyracksDataException.java +++ b/hyracks-fullstack/hyracks/hyracks-api/src/main/java/org/apache/hyracks/api/exceptions/HyracksDataException.java @@ -140,7 +140,9 @@ } public static HyracksDataException create(HyracksDataException e, String nodeId) { - return new HyracksDataException(e.getComponent(), e.getErrorCode(), e.getMessage(), e.getCause(), nodeId, + final HyracksDataException nodeScopedEx = new HyracksDataException(e.getComponent(), e.getErrorCode(), e.getMessage(), e.getCause(), nodeId, e.getParams()); + nodeScopedEx.setStackTrace(e.getStackTrace()); + return nodeScopedEx; } } diff --git a/hyracks-fullstack/hyracks/hyracks-api/src/main/java/org/apache/hyracks/api/exceptions/HyracksException.java b/hyracks-fullstack/hyracks/hyracks-api/src/main/java/org/apache/hyracks/api/exceptions/HyracksException.java index 3aa95b3..20ef8a3 100644 --- a/hyracks-fullstack/hyracks/hyracks-api/src/main/java/org/apache/hyracks/api/exceptions/HyracksException.java +++ b/hyracks-fullstack/hyracks/hyracks-api/src/main/java/org/apache/hyracks/api/exceptions/HyracksException.java @@ -30,7 +30,7 @@ private final String component; private final int errorCode; private final Serializable[] params; - private final String nodeId; + private String nodeId; private transient volatile String msgCache; public static HyracksException create(Throwable cause) { diff --git a/hyracks-fullstack/hyracks/hyracks-control/hyracks-control-cc/src/main/java/org/apache/hyracks/control/cc/ClusterControllerIPCI.java b/hyracks-fullstack/hyracks/hyracks-control/hyracks-control-cc/src/main/java/org/apache/hyracks/control/cc/ClusterControllerIPCI.java index 350984c..af5c102 100644 --- a/hyracks-fullstack/hyracks/hyracks-control/hyracks-control-cc/src/main/java/org/apache/hyracks/control/cc/ClusterControllerIPCI.java +++ b/hyracks-fullstack/hyracks/hyracks-control/hyracks-control-cc/src/main/java/org/apache/hyracks/control/cc/ClusterControllerIPCI.java @@ -72,8 +72,7 @@ break; case NODE_HEARTBEAT: CCNCFunctions.NodeHeartbeatFunction nhf = (CCNCFunctions.NodeHeartbeatFunction) fn; - ccs.getWorkQueue().schedule(new NodeHeartbeatWork(ccs, nhf.getNodeId(), - nhf.getHeartbeatData())); + ccs.getExecutor().execute(new NodeHeartbeatWork(ccs, nhf.getNodeId(), nhf.getHeartbeatData())); break; case NOTIFY_JOBLET_CLEANUP: CCNCFunctions.NotifyJobletCleanupFunction njcf = (CCNCFunctions.NotifyJobletCleanupFunction) fn; -- To view, visit https://asterix-gerrit.ics.uci.edu/2138 To unsubscribe, visit https://asterix-gerrit.ics.uci.edu/settings Gerrit-MessageType: newchange Gerrit-Change-Id: If8fd35a7fd488bed5f1d5e2146dd48892cb0a7a4 Gerrit-PatchSet: 1 Gerrit-Project: asterixdb Gerrit-Branch: release-0.9.3-pre-rc Gerrit-Owner: Michael Blow