Mailing-List: contact notifications-help@asterixdb.apache.org; run by ezmlm
Precedence: bulk
Reply-To: dev@asterixdb.apache.org
Date: Mon, 27 Nov 2017 11:14:47 -0800
From: "Luo Chen (Code Review)" <do-not-reply@asterixdb.incubator.apache.org>
CC: Jenkins <jenkins@fulliautomatix.ics.uci.edu>,
	abdullah alamoudi <bamousaa@gmail.com>,
	Ian Maxon <imaxon@apache.org>, Till Westmann <tillw@apache.org>,
	Jianfeng Jia <jianfeng.jia@gmail.com>,
	Wail Alkowaileet <wael.y.k@gmail.com>
Reply-To: cluo8@uci.edu
Subject: Change in asterixdb[master]: [ASTERIXDB-2149] Enable multiple normalized keys in sort
In-Reply-To: <gerrit.1509911088913.I4354242ff731b4b006b8446b58f65873047dde78@asterix-gerrit.ics.uci.edu>
References: <gerrit.1509911088913.I4354242ff731b4b006b8446b58f65873047dde78@asterix-gerrit.ics.uci.edu>
MIME-Version: 1.0
Content-Type: text/plain; charset=UTF-8
Content-Transfer-Encoding: 8bit
Content-Disposition: inline
User-Agent: Gerrit/2.12.7
Message-Id: <20171127191447.54A80100747@vitalstatistix.ics.uci.edu>
archived-at: Mon, 27 Nov 2017 19:14:51 -0000

Luo Chen has posted comments on this change.

Change subject: [ASTERIXDB-2149] Enable multiple normalized keys in sort
......................................................................


Patch Set 8:

(1 comment)

https://asterix-gerrit.ics.uci.edu/#/c/2127/7/hyracks-fullstack/hyracks/hyracks-dataflow-std/src/main/java/org/apache/hyracks/dataflow/std/group/sort/SortGroupByOperatorDescriptor.java
File hyracks-fullstack/hyracks/hyracks-dataflow-std/src/main/java/org/apache/hyracks/dataflow/std/group/sort/SortGroupByOperatorDescriptor.java:

PS7, Line 97:  @param spec
            :      *            the Hyracks job specification
            :      * @param framesLimit
            :      *            the frame limit for this operator
            :      * @param sortFields
            :      *            the fields to sort
            :      * @param groupFields
            :      *            the fields to group, which can be a prefix subset of sortFields
            :      * @param keyNormalizerFactories
            :      *            the normalized key computer factories for the prefix the sortFields
            :      * @param comparatorFactories
            :      *            the comparator factories of sort keys
            :      * @param partialAggregatorFactory
            :      *            for aggregating the input of this operator
            :      * @param mergeAggregatorFactory
            :      *            for aggregating the intermediate data of this operator
            :      * @param partialAggRecordDesc
            :      *            the record descriptor of intermediate data
            :      * @param outRecordDesc
            :      *            the record descriptor of output data
            :      * @param finalStage
            :      *            whether the operator is used for final
> remove the commas?
Done


-- 
To view, visit https://asterix-gerrit.ics.uci.edu/2127
To unsubscribe, visit https://asterix-gerrit.ics.uci.edu/settings

Gerrit-MessageType: comment
Gerrit-Change-Id: I4354242ff731b4b006b8446b58f65873047dde78
Gerrit-PatchSet: 8
Gerrit-Project: asterixdb
Gerrit-Branch: master
Gerrit-Owner: Luo Chen <cluo8@uci.edu>
Gerrit-Reviewer: Anon. E. Moose #1000171
Gerrit-Reviewer: Ian Maxon <imaxon@apache.org>
Gerrit-Reviewer: Jenkins <jenkins@fulliautomatix.ics.uci.edu>
Gerrit-Reviewer: Jianfeng Jia <jianfeng.jia@gmail.com>
Gerrit-Reviewer: Luo Chen <cluo8@uci.edu>
Gerrit-Reviewer: Till Westmann <tillw@apache.org>
Gerrit-Reviewer: Wail Alkowaileet <wael.y.k@gmail.com>
Gerrit-Reviewer: abdullah alamoudi <bamousaa@gmail.com>
Gerrit-HasComments: Yes