Return-Path: X-Original-To: archive-asf-public-internal@cust-asf2.ponee.io Delivered-To: archive-asf-public-internal@cust-asf2.ponee.io Received: from cust-asf.ponee.io (cust-asf.ponee.io [163.172.22.183]) by cust-asf2.ponee.io (Postfix) with ESMTP id A2CA6200D48 for ; Wed, 15 Nov 2017 00:31:45 +0100 (CET) Received: by cust-asf.ponee.io (Postfix) id A152D160C07; Tue, 14 Nov 2017 23:31:45 +0000 (UTC) Delivered-To: archive-asf-public@cust-asf.ponee.io Received: from mail.apache.org (hermes.apache.org [140.211.11.3]) by cust-asf.ponee.io (Postfix) with SMTP id E9032160BF4 for ; Wed, 15 Nov 2017 00:31:44 +0100 (CET) Received: (qmail 80255 invoked by uid 500); 14 Nov 2017 23:31:44 -0000 Mailing-List: contact notifications-help@asterixdb.apache.org; run by ezmlm Precedence: bulk List-Help: List-Unsubscribe: List-Post: List-Id: Reply-To: dev@asterixdb.apache.org Delivered-To: mailing list notifications@asterixdb.apache.org Received: (qmail 80245 invoked by uid 99); 14 Nov 2017 23:31:44 -0000 Received: from pnap-us-west-generic-nat.apache.org (HELO spamd1-us-west.apache.org) (209.188.14.142) by apache.org (qpsmtpd/0.29) with ESMTP; Tue, 14 Nov 2017 23:31:44 +0000 Received: from localhost (localhost [127.0.0.1]) by spamd1-us-west.apache.org (ASF Mail Server at spamd1-us-west.apache.org) with ESMTP id 733B0C8B86 for ; Tue, 14 Nov 2017 23:31:43 +0000 (UTC) X-Virus-Scanned: Debian amavisd-new at spamd1-us-west.apache.org X-Spam-Flag: NO X-Spam-Score: 2.127 X-Spam-Level: ** X-Spam-Status: No, score=2.127 tagged_above=-999 required=6.31 tests=[MISSING_HEADERS=1.207, SPF_FAIL=0.919, URIBL_BLOCKED=0.001] autolearn=disabled Received: from mx1-lw-eu.apache.org ([10.40.0.8]) by localhost (spamd1-us-west.apache.org [10.40.0.7]) (amavisd-new, port 10024) with ESMTP id geKDVjjKeDl7 for ; Tue, 14 Nov 2017 23:31:42 +0000 (UTC) Received: from vitalstatistix.ics.uci.edu (vitalstatistix.ics.uci.edu [128.195.52.38]) by mx1-lw-eu.apache.org (ASF Mail Server at mx1-lw-eu.apache.org) with ESMTP id 3A9B95FDE7 for ; Tue, 14 Nov 2017 23:31:42 +0000 (UTC) Received: from localhost (localhost [127.0.0.1]) by vitalstatistix.ics.uci.edu (Postfix) with ESMTP id 81505100B01; Tue, 14 Nov 2017 15:31:41 -0800 (PST) Date: Tue, 14 Nov 2017 15:31:41 -0800 From: "Murtadha Hubail (Code Review)" CC: Jenkins , Michael Blow Reply-To: mhubail@apache.org X-Gerrit-MessageType: comment Subject: Change in asterixdb[master]: [NO ISSUE][TX] Ensure TxnIdFactory Value is Initialized X-Gerrit-Change-Id: I6899c9e7d6e744ca92d0108556e086a23639d78b X-Gerrit-ChangeURL: X-Gerrit-Commit: de2336239c0248a899873592de1698fb70eef7c0 In-Reply-To: References: MIME-Version: 1.0 Content-Type: text/plain; charset=UTF-8 Content-Transfer-Encoding: 8bit Content-Disposition: inline User-Agent: Gerrit/2.12.7 Message-Id: <20171114233141.81505100B01@vitalstatistix.ics.uci.edu> archived-at: Tue, 14 Nov 2017 23:31:45 -0000 Murtadha Hubail has posted comments on this change. Change subject: [NO ISSUE][TX] Ensure TxnIdFactory Value is Initialized ...................................................................... Patch Set 2: (1 comment) https://asterix-gerrit.ics.uci.edu/#/c/2151/2/asterixdb/asterix-app/src/main/java/org/apache/asterix/app/replication/NoFaultToleranceStrategy.java File asterixdb/asterix-app/src/main/java/org/apache/asterix/app/replication/NoFaultToleranceStrategy.java: PS2, Line 134: * > shouldn't javadocs be on methods, fields, and types? Where does the javado It doesn't, but I don't know if there is any harm in doing that. The nice thing about this is that if we rename something, the comment will be updated. At the same time, javadoc tool ignores those comments for statements. In any case, I will remove it. -- To view, visit https://asterix-gerrit.ics.uci.edu/2151 To unsubscribe, visit https://asterix-gerrit.ics.uci.edu/settings Gerrit-MessageType: comment Gerrit-Change-Id: I6899c9e7d6e744ca92d0108556e086a23639d78b Gerrit-PatchSet: 2 Gerrit-Project: asterixdb Gerrit-Branch: master Gerrit-Owner: Murtadha Hubail Gerrit-Reviewer: Anon. E. Moose #1000171 Gerrit-Reviewer: Jenkins Gerrit-Reviewer: Michael Blow Gerrit-Reviewer: Murtadha Hubail Gerrit-HasComments: Yes