Mailing-List: contact notifications-help@asterixdb.apache.org; run by ezmlm
Precedence: bulk
Reply-To: dev@asterixdb.apache.org
Date: Mon, 13 Nov 2017 16:28:10 -0800
From: "Xikui Wang (Code Review)" <do-not-reply@asterixdb.incubator.apache.org>
To: Steven Jacobs <sjaco002@ucr.edu>
CC: Ildar Absalyamov <ildar.absalyamov@gmail.com>,
	abdullah alamoudi <bamousaa@gmail.com>,
	Till Westmann <tillw@apache.org>,
	Dmitry Lychagin <dmitry.lychagin@couchbase.com>,
	Jenkins <jenkins@fulliautomatix.ics.uci.edu>
Reply-To: xkkwww@gmail.com
Subject: Change in asterixdb[master]: [ASTERIXDB-1911][HYR,RT,CLUS] Fixes and Improvements for Pre...
In-Reply-To: <gerrit.1506970371206.I8f493c1fa977d07dfe8a875f9ebe9515d01d1473@asterix-gerrit.ics.uci.edu>
References: <gerrit.1506970371206.I8f493c1fa977d07dfe8a875f9ebe9515d01d1473@asterix-gerrit.ics.uci.edu>
MIME-Version: 1.0
Content-Type: text/plain; charset=UTF-8
Content-Transfer-Encoding: 8bit
Content-Disposition: inline
User-Agent: Gerrit/2.12.7
Message-Id: <20171114002810.6BE7D100738@vitalstatistix.ics.uci.edu>
archived-at: Tue, 14 Nov 2017 00:28:35 -0000

Xikui Wang has posted comments on this change.

Change subject: [ASTERIXDB-1911][HYR,RT,CLUS] Fixes and Improvements for PreDistributed Jobs
......................................................................


Patch Set 22:

(4 comments)

Several comments about minor issues.

https://asterix-gerrit.ics.uci.edu/#/c/2045/22/asterixdb/asterix-active/src/main/java/org/apache/asterix/active/DeployedJobService.java
File asterixdb/asterix-active/src/main/java/org/apache/asterix/active/DeployedJobService.java:

Line 46:     private static final int poolSize = 1;
> MAJOR SonarQube violation:
please address this.


https://asterix-gerrit.ics.uci.edu/#/c/2045/22/hyracks-fullstack/hyracks/hyracks-examples/hyracks-integration-tests/src/test/java/org/apache/hyracks/tests/integration/DeployedJobSpecsTest.java
File hyracks-fullstack/hyracks/hyracks-examples/hyracks-integration-tests/src/test/java/org/apache/hyracks/tests/integration/DeployedJobSpecsTest.java:

Line 129:         verify(cc, Mockito.timeout(5000).times(4)).getDeployedJobSpecStore();
use a single private static final int to replace this and all following occurrences.  it would be better to have a meaningful name.


Line 130:         verify(nc1, Mockito.timeout(5000).times(2)).storeActivityClusterGraph(any(), any());
Is there any particular reason to chose 4,2,8,12 for the times?


Line 173:         Thread.sleep(10000);
> MAJOR SonarQube violation:
do we have more deterministic method instead of sleep? this is likely to fail if the system is overloaded. Also, sleep 10 seconds for each build seems expensive too (if we have a better solution)...


-- 
To view, visit https://asterix-gerrit.ics.uci.edu/2045
To unsubscribe, visit https://asterix-gerrit.ics.uci.edu/settings

Gerrit-MessageType: comment
Gerrit-Change-Id: I8f493c1fa977d07dfe8a875f9ebe9515d01d1473
Gerrit-PatchSet: 22
Gerrit-Project: asterixdb
Gerrit-Branch: master
Gerrit-Owner: Steven Jacobs <sjaco002@ucr.edu>
Gerrit-Reviewer: Anon. E. Moose #1000171
Gerrit-Reviewer: Dmitry Lychagin <dmitry.lychagin@couchbase.com>
Gerrit-Reviewer: Ildar Absalyamov <ildar.absalyamov@gmail.com>
Gerrit-Reviewer: Jenkins <jenkins@fulliautomatix.ics.uci.edu>
Gerrit-Reviewer: Steven Jacobs <sjaco002@ucr.edu>
Gerrit-Reviewer: Till Westmann <tillw@apache.org>
Gerrit-Reviewer: Xikui Wang <xkkwww@gmail.com>
Gerrit-Reviewer: abdullah alamoudi <bamousaa@gmail.com>
Gerrit-HasComments: Yes