Mailing-List: contact notifications-help@asterixdb.apache.org; run by ezmlm
Precedence: bulk
Reply-To: dev@asterixdb.apache.org
Date: Mon, 6 Nov 2017 00:36:29 -0800
From: "Taewoo Kim (Code Review)" <do-not-reply@asterixdb.incubator.apache.org>
To: Taewoo Kim <wangsaeu@gmail.com>
CC: Jenkins <jenkins@fulliautomatix.ics.uci.edu>,
	Till Westmann <tillw@apache.org>,
	abdullah alamoudi <bamousaa@gmail.com>
Reply-To: wangsaeu@gmail.com
Subject: Change in asterixdb[master]: [NO ISSUE][RT][IDX] Simplify index.createAccessor()
In-Reply-To: <gerrit.1509571394837.Iae015c342e830c81d666428447b595280139740e@asterix-gerrit.ics.uci.edu>
References: <gerrit.1509571394837.Iae015c342e830c81d666428447b595280139740e@asterix-gerrit.ics.uci.edu>
MIME-Version: 1.0
Content-Type: text/plain; charset=UTF-8
Content-Transfer-Encoding: 8bit
Content-Disposition: inline
User-Agent: Gerrit/2.12.7
Message-Id: <20171106083629.1844C100810@vitalstatistix.ics.uci.edu>
archived-at: Mon, 06 Nov 2017 08:36:33 -0000

Taewoo Kim has posted comments on this change.

Change subject: [NO ISSUE][RT][IDX] Simplify index.createAccessor()
......................................................................


Patch Set 6:

(1 comment)

@Abdullah: thanks for the comment. @Till: how's your thought on his comment?

https://asterix-gerrit.ics.uci.edu/#/c/2120/6/hyracks-fullstack/hyracks/hyracks-storage-common/src/main/java/org/apache/hyracks/storage/common/IIndexAccessParameters.java
File hyracks-fullstack/hyracks/hyracks-storage-common/src/main/java/org/apache/hyracks/storage/common/IIndexAccessParameters.java:

PS6, Line 42: Map<String, Object> getParametersMap();
> why don't we make the interface have:
What you mean is the following? I think put and get implies that we use a map or list. :-) I am fine with this approach, too. How's your thought? @Till?

void put(String name, Object value)
Object get(String name)


-- 
To view, visit https://asterix-gerrit.ics.uci.edu/2120
To unsubscribe, visit https://asterix-gerrit.ics.uci.edu/settings

Gerrit-MessageType: comment
Gerrit-Change-Id: Iae015c342e830c81d666428447b595280139740e
Gerrit-PatchSet: 6
Gerrit-Project: asterixdb
Gerrit-Branch: master
Gerrit-Owner: Taewoo Kim <wangsaeu@gmail.com>
Gerrit-Reviewer: Anon. E. Moose #1000171
Gerrit-Reviewer: Jenkins <jenkins@fulliautomatix.ics.uci.edu>
Gerrit-Reviewer: Taewoo Kim <wangsaeu@gmail.com>
Gerrit-Reviewer: Till Westmann <tillw@apache.org>
Gerrit-Reviewer: abdullah alamoudi <bamousaa@gmail.com>
Gerrit-HasComments: Yes