asterixdb-notifications mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From "Murtadha Hubail (Code Review)" <do-not-re...@asterixdb.incubator.apache.org>
Subject Change in asterixdb[master]: [NO ISSUE][TX] Ensure TxnIdFactory Value is Initialized
Date Tue, 14 Nov 2017 23:31:41 GMT
Murtadha Hubail has posted comments on this change.

Change subject: [NO ISSUE][TX] Ensure TxnIdFactory Value is Initialized
......................................................................


Patch Set 2:

(1 comment)

https://asterix-gerrit.ics.uci.edu/#/c/2151/2/asterixdb/asterix-app/src/main/java/org/apache/asterix/app/replication/NoFaultToleranceStrategy.java
File asterixdb/asterix-app/src/main/java/org/apache/asterix/app/replication/NoFaultToleranceStrategy.java:

PS2, Line 134: *
> shouldn't javadocs be on methods, fields, and types?  Where does the javado
It doesn't, but I don't know if there is any harm in doing that. The nice thing about this
is that if we rename something, the comment will be updated. At the same time, javadoc tool
ignores those comments for statements. In any case, I will remove it.


-- 
To view, visit https://asterix-gerrit.ics.uci.edu/2151
To unsubscribe, visit https://asterix-gerrit.ics.uci.edu/settings

Gerrit-MessageType: comment
Gerrit-Change-Id: I6899c9e7d6e744ca92d0108556e086a23639d78b
Gerrit-PatchSet: 2
Gerrit-Project: asterixdb
Gerrit-Branch: master
Gerrit-Owner: Murtadha Hubail <mhubail@apache.org>
Gerrit-Reviewer: Anon. E. Moose #1000171
Gerrit-Reviewer: Jenkins <jenkins@fulliautomatix.ics.uci.edu>
Gerrit-Reviewer: Michael Blow <mblow@apache.org>
Gerrit-Reviewer: Murtadha Hubail <mhubail@apache.org>
Gerrit-HasComments: Yes

Mime
View raw message