asterixdb-notifications mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From "abdullah alamoudi (Code Review)" <do-not-re...@asterixdb.incubator.apache.org>
Subject Change in asterixdb[release-0.9.3-pre-rc]: [NO ISSUE][TX] Fix DatasetLock for Multiple Index Builds
Date Mon, 13 Nov 2017 01:21:39 GMT
Hello Anon. E. Moose #1000171, Jenkins,

I'd like you to reexamine a change.  Please visit

    https://asterix-gerrit.ics.uci.edu/2144

to look at the new patch set (#9).

Change subject: [NO ISSUE][TX] Fix DatasetLock for Multiple Index Builds
......................................................................

[NO ISSUE][TX] Fix DatasetLock for Multiple Index Builds

- user model changes: no
- storage format changes: no
- interface changes: no

details:
- The mechanism used for allowing multiple concurrent index
  builds does not work if the first index build finishes
  before other index builds. It relied on a write lock
  obtained by the first index builder and released by
  the last index builder. This is not allowed when using
  ReentrantReadWriteLock and will lead to an
  IllegalMonitorStateException since the last thread to exit
  did not hold the lock.
- Potential Deadlock between modify and exclusive modify can
  happen when an exclusive modify attempts to upgrade the
  lock to write lock while the modify lock waits for the
  exclusive lock to release. This has been fixed too.
- Test cases were added.

Change-Id: I3bea3ff2075d952ab13402b0c445c464b431c0f5
---
M asterixdb/asterix-app/src/main/java/org/apache/asterix/app/active/RecoveryTask.java
M asterixdb/asterix-metadata/src/main/java/org/apache/asterix/metadata/lock/DatasetLock.java
A asterixdb/asterix-metadata/src/test/java/org/apache/asterix/metadata/lock/MetadataLockManagerTest.java
3 files changed, 384 insertions(+), 39 deletions(-)


  git pull ssh://asterix-gerrit.ics.uci.edu:29418/asterixdb refs/changes/44/2144/9
-- 
To view, visit https://asterix-gerrit.ics.uci.edu/2144
To unsubscribe, visit https://asterix-gerrit.ics.uci.edu/settings

Gerrit-MessageType: newpatchset
Gerrit-Change-Id: I3bea3ff2075d952ab13402b0c445c464b431c0f5
Gerrit-PatchSet: 9
Gerrit-Project: asterixdb
Gerrit-Branch: release-0.9.3-pre-rc
Gerrit-Owner: abdullah alamoudi <bamousaa@gmail.com>
Gerrit-Reviewer: Anon. E. Moose #1000171
Gerrit-Reviewer: Jenkins <jenkins@fulliautomatix.ics.uci.edu>
Gerrit-Reviewer: Michael Blow <mblow@apache.org>
Gerrit-Reviewer: Murtadha Hubail <mhubail@apache.org>
Gerrit-Reviewer: Till Westmann <tillw@apache.org>
Gerrit-Reviewer: abdullah alamoudi <bamousaa@gmail.com>

Mime
View raw message