asterixdb-notifications mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From "Murtadha Hubail (Code Review)" <do-not-re...@asterixdb.incubator.apache.org>
Subject Change in asterixdb[master]: [ASTERIXDB-1871][ASTERIXDB-2095] Stop Consumer Thread on Dea...
Date Fri, 10 Nov 2017 15:17:47 GMT
Hello Jenkins,

I'd like you to reexamine a change.  Please visit

    https://asterix-gerrit.ics.uci.edu/2143

to look at the new patch set (#5).

Change subject: [ASTERIXDB-1871][ASTERIXDB-2095] Stop Consumer Thread on Deallocate
......................................................................

[ASTERIXDB-1871][ASTERIXDB-2095] Stop Consumer Thread on Deallocate

- user model changes: no
- storage format changes: no
- interface changes: no

Details:

- Currently there is a chance that a MaterializingPipelinedPartition
  is deallocated before the consuming thread starts (e.g. due to job
  abort) and therefore the consuming thread will not be interrupted
  leading to leaked threads and files. This change checks if partition
  was deallocated before the consumer starts, then the consumer thread
  cleans up any files then exits.
- Make TaskAttemptId non-final class to mock it.
- Add test case.

Change-Id: I18c9fb085c149f41a202fff83aa6ec3aaeba6a77
---
M asterixdb/asterix-app/pom.xml
M asterixdb/asterix-app/src/test/java/org/apache/asterix/test/runtime/LangExecutionUtil.java
A asterixdb/asterix-app/src/test/java/org/apache/asterix/test/storage/DeallocatableTest.java
M asterixdb/asterix-replication/src/main/java/org/apache/asterix/replication/management/NetworkingUtil.java
M hyracks-fullstack/hyracks/hyracks-api/src/main/java/org/apache/hyracks/api/dataflow/TaskAttemptId.java
M hyracks-fullstack/hyracks/hyracks-control/hyracks-control-nc/src/main/java/org/apache/hyracks/control/nc/partitions/MaterializingPipelinedPartition.java
6 files changed, 117 insertions(+), 19 deletions(-)


  git pull ssh://asterix-gerrit.ics.uci.edu:29418/asterixdb refs/changes/43/2143/5
-- 
To view, visit https://asterix-gerrit.ics.uci.edu/2143
To unsubscribe, visit https://asterix-gerrit.ics.uci.edu/settings

Gerrit-MessageType: newpatchset
Gerrit-Change-Id: I18c9fb085c149f41a202fff83aa6ec3aaeba6a77
Gerrit-PatchSet: 5
Gerrit-Project: asterixdb
Gerrit-Branch: master
Gerrit-Owner: Murtadha Hubail <mhubail@apache.org>
Gerrit-Reviewer: Jenkins <jenkins@fulliautomatix.ics.uci.edu>

Mime
View raw message