asterixdb-notifications mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From "Luo Chen (Code Review)" <do-not-re...@asterixdb.incubator.apache.org>
Subject Change in asterixdb[master]: [NO ISSUE][STO] Add a callback on recycling of memory compon...
Date Sun, 05 Nov 2017 16:48:43 GMT
Luo Chen has posted comments on this change.

Change subject: [NO ISSUE][STO] Add a callback on recycling of memory components
......................................................................


Patch Set 3:

(2 comments)

A few minor comments...

https://asterix-gerrit.ics.uci.edu/#/c/2125/3/asterixdb/asterix-common/src/main/java/org/apache/asterix/common/context/DatasetResource.java
File asterixdb/asterix-common/src/main/java/org/apache/asterix/common/context/DatasetResource.java:

PS3, Line 95: index.getNumberOfMemoryComponents() == 0
I think this method might be a bit confusing. In our implementation, the LSM index can have
N memory components (for most of the time, N = 2), but only 1 of them is currently active.
So this method should return N or 1?


https://asterix-gerrit.ics.uci.edu/#/c/2125/3/hyracks-fullstack/hyracks/hyracks-storage-am-lsm-common/src/main/java/org/apache/hyracks/storage/am/lsm/common/impls/AbstractLSMMemoryComponent.java
File hyracks-fullstack/hyracks/hyracks-storage-am-lsm-common/src/main/java/org/apache/hyracks/storage/am/lsm/common/impls/AbstractLSMMemoryComponent.java:

PS3, Line 43: if (isActive) {
            :             state = ComponentState.READABLE_WRITABLE;
            :         } else {
            :             state = ComponentState.INACTIVE;
            :         }
I think we should capture this piece of code with componentRecycled as well?
We could either remove 'isActive' parameter, and let the caller always call 'requestActivation';
or, also call ioOperationCallback.componentRecycled here.


-- 
To view, visit https://asterix-gerrit.ics.uci.edu/2125
To unsubscribe, visit https://asterix-gerrit.ics.uci.edu/settings

Gerrit-MessageType: comment
Gerrit-Change-Id: Iec9302a512990eac3937fb711b591b6f19ef87e2
Gerrit-PatchSet: 3
Gerrit-Project: asterixdb
Gerrit-Branch: master
Gerrit-Owner: abdullah alamoudi <bamousaa@gmail.com>
Gerrit-Reviewer: Ian Maxon <imaxon@apache.org>
Gerrit-Reviewer: Jenkins <jenkins@fulliautomatix.ics.uci.edu>
Gerrit-Reviewer: Luo Chen <cluo8@uci.edu>
Gerrit-Reviewer: Murtadha Hubail <mhubail@apache.org>
Gerrit-Reviewer: Taewoo Kim <taewok2@uci.edu>
Gerrit-Reviewer: Till Westmann <tillw@apache.org>
Gerrit-HasComments: Yes

Mime
View raw message