asterixdb-notifications mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From "Ian Maxon (Code Review)" <do-not-re...@asterixdb.incubator.apache.org>
Subject Change in asterixdb[master]: [ASTERIXDB-2154][COMP] Extensible built-in function management
Date Fri, 03 Nov 2017 01:27:34 GMT
Ian Maxon has posted comments on this change.

Change subject: [ASTERIXDB-2154][COMP] Extensible built-in function management
......................................................................


Patch Set 2: Code-Review+1

(1 comment)

Seems good to me.

https://asterix-gerrit.ics.uci.edu/#/c/2118/2/asterixdb/asterix-app/src/main/java/org/apache/asterix/app/cc/CCExtensionManager.java
File asterixdb/asterix-app/src/main/java/org/apache/asterix/app/cc/CCExtensionManager.java:

PS2, Line 76: Set<ExtensionId> extensionIds = new HashSet<>()
So this is just to check that we're not getting duplicate extensions?


-- 
To view, visit https://asterix-gerrit.ics.uci.edu/2118
To unsubscribe, visit https://asterix-gerrit.ics.uci.edu/settings

Gerrit-MessageType: comment
Gerrit-Change-Id: Iafbf7e4e298fb7af6cb84b402cb00cfa2e90b5ce
Gerrit-PatchSet: 2
Gerrit-Project: asterixdb
Gerrit-Branch: master
Gerrit-Owner: Dmitry Lychagin <dmitry.lychagin@couchbase.com>
Gerrit-Reviewer: Ian Maxon <imaxon@apache.org>
Gerrit-Reviewer: Jenkins <jenkins@fulliautomatix.ics.uci.edu>
Gerrit-Reviewer: Luo Chen <cluo8@uci.edu>
Gerrit-Reviewer: Taewoo Kim <wangsaeu@gmail.com>
Gerrit-Reviewer: Till Westmann <tillw@apache.org>
Gerrit-Reviewer: Xikui Wang <xkkwww@gmail.com>
Gerrit-HasComments: Yes

Mime
View raw message