asterixdb-notifications mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From "Luo Chen (Code Review)" <do-not-re...@asterixdb.incubator.apache.org>
Subject Change in asterixdb[master]: [ASTERIXDB-1952][TX][IDX]Filter logs pt.2
Date Thu, 02 Nov 2017 22:45:00 GMT
Luo Chen has posted comments on this change.

Change subject: [ASTERIXDB-1952][TX][IDX]Filter logs pt.2
......................................................................


Patch Set 19:

(4 comments)

https://asterix-gerrit.ics.uci.edu/#/c/1857/19/asterixdb/asterix-common/src/main/java/org/apache/asterix/common/transactions/LogRecord.java
File asterixdb/asterix-common/src/main/java/org/apache/asterix/common/transactions/LogRecord.java:

PS19, Line 64:  * 2) ENTITY_COMMIT || UPSERT_ENTITY_COMMIT: (Header1(6) + Header2(8) + Header3(8)
+ Tail(8)) + PKValueSize
             :  * --> ENTITY_COMMIT_LOG_BASE_SIZE = 30
             :  * 3) UPDATE: (Header1(6) + Header2(8) + Header3(8) + Header4(20) + Body(9)
+ Tail(8)) + PKValueSize + NewValueSize
             :  * --> UPDATE_LOG_BASE_SIZE = 51
             :  * 4) FILTER: (Header1(6) + Header2(8) + Body(9) + Tail(8))
Why change other log record format as well (in additional to filter)?


https://asterix-gerrit.ics.uci.edu/#/c/1857/19/hyracks-fullstack/hyracks/hyracks-storage-am-lsm-common/src/main/java/org/apache/hyracks/storage/am/lsm/common/api/ILSMHarness.java
File hyracks-fullstack/hyracks/hyracks-storage-am-lsm-common/src/main/java/org/apache/hyracks/storage/am/lsm/common/api/ILSMHarness.java:

PS19, Line 221:   /**
              :      * Update the filter with the value in the passed tuple
              :      *
              :      * @param ctx
              :      * @throws HyracksDataException
              :      */
              :     void updateFilter(ILSMIndexOperationContext ctx, ITupleReference tuple)
throws HyracksDataException;
              : 
              :     /**
              :      * Update the filter with the value in the passed tuple, also give the
tuple to the modification callback
              :      *
              :      * @param ctx
              :      * @throws HyracksDataException
              :      */
              :     void updateFilter(ILSMIndexOperationContext ctx, ITupleReference tuple,
boolean callback)
              :             throws HyracksDataException;
              : 
              :     /**
Maybe we can merge two methods into one?
Or simply provide a default implementation for the first one?


https://asterix-gerrit.ics.uci.edu/#/c/1857/19/hyracks-fullstack/hyracks/hyracks-storage-am-lsm-common/src/main/java/org/apache/hyracks/storage/am/lsm/common/impls/LSMTreeIndexAccessor.java
File hyracks-fullstack/hyracks/hyracks-storage-am-lsm-common/src/main/java/org/apache/hyracks/storage/am/lsm/common/impls/LSMTreeIndexAccessor.java:

PS19, Line 214: public void updateFilter(ITupleReference tuple, boolean callback)
why do we have a almost identical method here? Or is it just a temp method, which will be
fixed later?


https://asterix-gerrit.ics.uci.edu/#/c/1857/19/hyracks-fullstack/hyracks/hyracks-storage-am-lsm-invertedindex/src/main/java/org/apache/hyracks/storage/am/lsm/invertedindex/impls/LSMInvertedIndexAccessor.java
File hyracks-fullstack/hyracks/hyracks-storage-am-lsm-invertedindex/src/main/java/org/apache/hyracks/storage/am/lsm/invertedindex/impls/LSMInvertedIndexAccessor.java:

PS19, Line 205:  public void updateFilter(ITupleReference tuple) throws HyracksDataException
{
There is no need to log filter for inverted index?


-- 
To view, visit https://asterix-gerrit.ics.uci.edu/1857
To unsubscribe, visit https://asterix-gerrit.ics.uci.edu/settings

Gerrit-MessageType: comment
Gerrit-Change-Id: Ie9e7795d9c8c212e8610dcb9bb5d26ec9fbbee8a
Gerrit-PatchSet: 19
Gerrit-Project: asterixdb
Gerrit-Branch: master
Gerrit-Owner: Ian Maxon <imaxon@apache.org>
Gerrit-Reviewer: Anon. E. Moose #1000171
Gerrit-Reviewer: Jenkins <jenkins@fulliautomatix.ics.uci.edu>
Gerrit-Reviewer: Jianfeng Jia <jianfeng.jia@gmail.com>
Gerrit-Reviewer: Luo Chen <cluo8@uci.edu>
Gerrit-Reviewer: Michael Blow <mblow@apache.org>
Gerrit-Reviewer: Murtadha Hubail <mhubail@apache.org>
Gerrit-Reviewer: Till Westmann <tillw@apache.org>
Gerrit-Reviewer: abdullah alamoudi <bamousaa@gmail.com>
Gerrit-HasComments: Yes

Mime
View raw message