asterixdb-notifications mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From "Taewoo Kim (Code Review)" <do-not-re...@asterixdb.incubator.apache.org>
Subject Change in asterixdb[master]: [NO ISSUE][RT][IDX] simplify createAccessor()
Date Thu, 02 Nov 2017 08:14:10 GMT
Taewoo Kim has posted comments on this change.

Change subject: [NO ISSUE][RT][IDX] simplify createAccessor()
......................................................................


Patch Set 1:

(1 comment)

Thanks Till!

https://asterix-gerrit.ics.uci.edu/#/c/2120/1/hyracks-fullstack/hyracks/hyracks-storage-common/src/main/java/org/apache/hyracks/storage/common/IIndexAccessContext.java
File hyracks-fullstack/hyracks/hyracks-storage-common/src/main/java/org/apache/hyracks/storage/common/IIndexAccessContext.java:

PS1, Line 27: IIndexAccessContext
> I'd prefer to call this IIndexAccessorParameters as this seems to describe 
Thanks Till. I totally agree. I am going to apply the changes that you proposed and upload
a new patch set.


-- 
To view, visit https://asterix-gerrit.ics.uci.edu/2120
To unsubscribe, visit https://asterix-gerrit.ics.uci.edu/settings

Gerrit-MessageType: comment
Gerrit-Change-Id: Iae015c342e830c81d666428447b595280139740e
Gerrit-PatchSet: 1
Gerrit-Project: asterixdb
Gerrit-Branch: master
Gerrit-Owner: Taewoo Kim <wangsaeu@gmail.com>
Gerrit-Reviewer: Anon. E. Moose #1000171
Gerrit-Reviewer: Jenkins <jenkins@fulliautomatix.ics.uci.edu>
Gerrit-Reviewer: Taewoo Kim <wangsaeu@gmail.com>
Gerrit-Reviewer: Till Westmann <tillw@apache.org>
Gerrit-Reviewer: abdullah alamoudi <bamousaa@gmail.com>
Gerrit-HasComments: Yes

Mime
View raw message