Return-Path: X-Original-To: archive-asf-public-internal@cust-asf2.ponee.io Delivered-To: archive-asf-public-internal@cust-asf2.ponee.io Received: from cust-asf.ponee.io (cust-asf.ponee.io [163.172.22.183]) by cust-asf2.ponee.io (Postfix) with ESMTP id CA235200D23 for ; Thu, 5 Oct 2017 04:55:57 +0200 (CEST) Received: by cust-asf.ponee.io (Postfix) id C8638160BD7; Thu, 5 Oct 2017 02:55:57 +0000 (UTC) Delivered-To: archive-asf-public@cust-asf.ponee.io Received: from mail.apache.org (hermes.apache.org [140.211.11.3]) by cust-asf.ponee.io (Postfix) with SMTP id 19CAF1609DD for ; Thu, 5 Oct 2017 04:55:56 +0200 (CEST) Received: (qmail 39621 invoked by uid 500); 5 Oct 2017 02:55:56 -0000 Mailing-List: contact notifications-help@asterixdb.apache.org; run by ezmlm Precedence: bulk List-Help: List-Unsubscribe: List-Post: List-Id: Reply-To: dev@asterixdb.apache.org Delivered-To: mailing list notifications@asterixdb.apache.org Received: (qmail 39612 invoked by uid 99); 5 Oct 2017 02:55:56 -0000 Received: from pnap-us-west-generic-nat.apache.org (HELO spamd2-us-west.apache.org) (209.188.14.142) by apache.org (qpsmtpd/0.29) with ESMTP; Thu, 05 Oct 2017 02:55:56 +0000 Received: from localhost (localhost [127.0.0.1]) by spamd2-us-west.apache.org (ASF Mail Server at spamd2-us-west.apache.org) with ESMTP id 62A891A2957 for ; Thu, 5 Oct 2017 02:55:55 +0000 (UTC) X-Virus-Scanned: Debian amavisd-new at spamd2-us-west.apache.org X-Spam-Flag: NO X-Spam-Score: 4.072 X-Spam-Level: **** X-Spam-Status: No, score=4.072 tagged_above=-999 required=6.31 tests=[MISSING_HEADERS=1.207, REPLYTO_WITHOUT_TO_CC=1.946, SPF_FAIL=0.919] autolearn=disabled Received: from mx1-lw-eu.apache.org ([10.40.0.8]) by localhost (spamd2-us-west.apache.org [10.40.0.9]) (amavisd-new, port 10024) with ESMTP id QTSsL5sL9Cg3 for ; Thu, 5 Oct 2017 02:55:54 +0000 (UTC) Received: from vitalstatistix.ics.uci.edu (vitalstatistix.ics.uci.edu [128.195.52.38]) by mx1-lw-eu.apache.org (ASF Mail Server at mx1-lw-eu.apache.org) with ESMTP id 51EE25FC8F for ; Thu, 5 Oct 2017 02:55:53 +0000 (UTC) Received: from localhost (localhost [127.0.0.1]) by vitalstatistix.ics.uci.edu (Postfix) with ESMTP id CAAE8100A2F for ; Wed, 4 Oct 2017 19:55:46 -0700 (PDT) Date: Wed, 4 Oct 2017 19:55:46 -0700 From: "Murtadha Hubail (Code Review)" Message-ID: Reply-To: mhubail@apache.org X-Gerrit-MessageType: newchange Subject: Change in asterixdb-bad[master]: Adapt to QueryTranslator Changes X-Gerrit-Change-Id: I75cb1b9a355e3fcdf257550569a0f07d36fd2fb1 X-Gerrit-ChangeURL: X-Gerrit-Commit: 2013598678bd205bde376d5e4bf5bafae39490c4 MIME-Version: 1.0 Content-Type: text/plain; charset=UTF-8 Content-Transfer-Encoding: 8bit Content-Disposition: inline User-Agent: Gerrit/2.12.7 archived-at: Thu, 05 Oct 2017 02:55:58 -0000 Murtadha Hubail has uploaded a new change for review. https://asterix-gerrit.ics.uci.edu/2054 Change subject: Adapt to QueryTranslator Changes ...................................................................... Adapt to QueryTranslator Changes - Pass additional parameter to Create/Drop dataset statemenets. Change-Id: I75cb1b9a355e3fcdf257550569a0f07d36fd2fb1 --- M asterix-bad/src/main/java/org/apache/asterix/bad/lang/statement/ChannelDropStatement.java M asterix-bad/src/main/java/org/apache/asterix/bad/lang/statement/CreateChannelStatement.java 2 files changed, 5 insertions(+), 4 deletions(-) git pull ssh://asterix-gerrit.ics.uci.edu:29418/asterixdb-bad refs/changes/54/2054/1 diff --git a/asterix-bad/src/main/java/org/apache/asterix/bad/lang/statement/ChannelDropStatement.java b/asterix-bad/src/main/java/org/apache/asterix/bad/lang/statement/ChannelDropStatement.java index 43aa161..fb71770 100644 --- a/asterix-bad/src/main/java/org/apache/asterix/bad/lang/statement/ChannelDropStatement.java +++ b/asterix-bad/src/main/java/org/apache/asterix/bad/lang/statement/ChannelDropStatement.java @@ -124,11 +124,11 @@ //TODO: Prevent datasets for Channels from being dropped elsewhere DropDatasetStatement dropStmt = new DropDatasetStatement(new Identifier(dataverse), new Identifier(channel.getResultsDatasetName()), true); - ((QueryTranslator) statementExecutor).handleDatasetDropStatement(tempMdProvider, dropStmt, hcc); + ((QueryTranslator) statementExecutor).handleDatasetDropStatement(tempMdProvider, dropStmt, hcc, null); tempMdProvider.getLocks().reset(); dropStmt = new DropDatasetStatement(new Identifier(dataverse), new Identifier(channel.getSubscriptionsDataset()), true); - ((QueryTranslator) statementExecutor).handleDatasetDropStatement(tempMdProvider, dropStmt, hcc); + ((QueryTranslator) statementExecutor).handleDatasetDropStatement(tempMdProvider, dropStmt, hcc, null); //Remove the Channel Metadata MetadataManager.INSTANCE.deleteEntity(mdTxnCtx, channel); diff --git a/asterix-bad/src/main/java/org/apache/asterix/bad/lang/statement/CreateChannelStatement.java b/asterix-bad/src/main/java/org/apache/asterix/bad/lang/statement/CreateChannelStatement.java index 5c92cb5..a04ac49 100644 --- a/asterix-bad/src/main/java/org/apache/asterix/bad/lang/statement/CreateChannelStatement.java +++ b/asterix-bad/src/main/java/org/apache/asterix/bad/lang/statement/CreateChannelStatement.java @@ -198,9 +198,10 @@ //Run both statements to create datasets ((QueryTranslator) statementExecutor).handleCreateDatasetStatement(metadataProvider, createSubscriptionsDataset, - hcc); + hcc, null); metadataProvider.getLocks().reset(); - ((QueryTranslator) statementExecutor).handleCreateDatasetStatement(metadataProvider, createResultsDataset, hcc); + ((QueryTranslator) statementExecutor).handleCreateDatasetStatement(metadataProvider, createResultsDataset, hcc, + null); } -- To view, visit https://asterix-gerrit.ics.uci.edu/2054 To unsubscribe, visit https://asterix-gerrit.ics.uci.edu/settings Gerrit-MessageType: newchange Gerrit-Change-Id: I75cb1b9a355e3fcdf257550569a0f07d36fd2fb1 Gerrit-PatchSet: 1 Gerrit-Project: asterixdb-bad Gerrit-Branch: master Gerrit-Owner: Murtadha Hubail