Return-Path: X-Original-To: archive-asf-public-internal@cust-asf2.ponee.io Delivered-To: archive-asf-public-internal@cust-asf2.ponee.io Received: from cust-asf.ponee.io (cust-asf.ponee.io [163.172.22.183]) by cust-asf2.ponee.io (Postfix) with ESMTP id A5FA4200D1F for ; Fri, 13 Oct 2017 19:20:57 +0200 (CEST) Received: by cust-asf.ponee.io (Postfix) id A460D1609E9; Fri, 13 Oct 2017 17:20:57 +0000 (UTC) Delivered-To: archive-asf-public@cust-asf.ponee.io Received: from mail.apache.org (hermes.apache.org [140.211.11.3]) by cust-asf.ponee.io (Postfix) with SMTP id E97D71609CA for ; Fri, 13 Oct 2017 19:20:56 +0200 (CEST) Received: (qmail 37833 invoked by uid 500); 13 Oct 2017 17:20:56 -0000 Mailing-List: contact notifications-help@asterixdb.apache.org; run by ezmlm Precedence: bulk List-Help: List-Unsubscribe: List-Post: List-Id: Reply-To: dev@asterixdb.apache.org Delivered-To: mailing list notifications@asterixdb.apache.org Received: (qmail 37824 invoked by uid 99); 13 Oct 2017 17:20:56 -0000 Received: from pnap-us-west-generic-nat.apache.org (HELO spamd1-us-west.apache.org) (209.188.14.142) by apache.org (qpsmtpd/0.29) with ESMTP; Fri, 13 Oct 2017 17:20:56 +0000 Received: from localhost (localhost [127.0.0.1]) by spamd1-us-west.apache.org (ASF Mail Server at spamd1-us-west.apache.org) with ESMTP id 5B014C1498 for ; Fri, 13 Oct 2017 17:20:55 +0000 (UTC) X-Virus-Scanned: Debian amavisd-new at spamd1-us-west.apache.org X-Spam-Flag: NO X-Spam-Score: 0.92 X-Spam-Level: X-Spam-Status: No, score=0.92 tagged_above=-999 required=6.31 tests=[SPF_FAIL=0.919, URIBL_BLOCKED=0.001] autolearn=disabled Received: from mx1-lw-us.apache.org ([10.40.0.8]) by localhost (spamd1-us-west.apache.org [10.40.0.7]) (amavisd-new, port 10024) with ESMTP id wSb0I9zmRA9c for ; Fri, 13 Oct 2017 17:20:53 +0000 (UTC) Received: from vitalstatistix.ics.uci.edu (vitalstatistix.ics.uci.edu [128.195.52.38]) by mx1-lw-us.apache.org (ASF Mail Server at mx1-lw-us.apache.org) with ESMTP id 416D85F6CB for ; Fri, 13 Oct 2017 17:20:53 +0000 (UTC) Received: from localhost (localhost [127.0.0.1]) by vitalstatistix.ics.uci.edu (Postfix) with ESMTP id 71FF8100A34; Fri, 13 Oct 2017 10:20:47 -0700 (PDT) Date: Fri, 13 Oct 2017 10:20:47 -0700 From: "abdullah alamoudi (Code Review)" To: Ildar Absalyamov CC: Jenkins , Luo Chen , Ian Maxon , Wail Alkowaileet , Till Westmann Reply-To: bamousaa@gmail.com X-Gerrit-MessageType: comment Subject: Change in asterixdb[master]: [NO ISSUE][STO][IDX] LSM storage cleanup X-Gerrit-Change-Id: I6739d751b990e7a28e03e32a5de6e2b670d37a1e X-Gerrit-ChangeURL: X-Gerrit-Commit: cbbc4a87db2e318c8ed01902f25783473cbb640d In-Reply-To: References: MIME-Version: 1.0 Content-Type: text/plain; charset=UTF-8 Content-Transfer-Encoding: 8bit Content-Disposition: inline User-Agent: Gerrit/2.12.7 Message-Id: <20171013172047.71FF8100A34@vitalstatistix.ics.uci.edu> archived-at: Fri, 13 Oct 2017 17:20:57 -0000 abdullah alamoudi has posted comments on this change. Change subject: [NO ISSUE][STO][IDX] LSM storage cleanup ...................................................................... Patch Set 32: Ildar, see my last comment.... We should add javadocs to the new/changed interfaces. This will make clear what those interface/calls means and may reveal some design issues... Please, do that before we merge? I can point out those places if desired... -- To view, visit https://asterix-gerrit.ics.uci.edu/2014 To unsubscribe, visit https://asterix-gerrit.ics.uci.edu/settings Gerrit-MessageType: comment Gerrit-Change-Id: I6739d751b990e7a28e03e32a5de6e2b670d37a1e Gerrit-PatchSet: 32 Gerrit-Project: asterixdb Gerrit-Branch: master Gerrit-Owner: Ildar Absalyamov Gerrit-Reviewer: Anon. E. Moose #1000171 Gerrit-Reviewer: Ian Maxon Gerrit-Reviewer: Ildar Absalyamov Gerrit-Reviewer: Jenkins Gerrit-Reviewer: Luo Chen Gerrit-Reviewer: Till Westmann Gerrit-Reviewer: Wail Alkowaileet Gerrit-Reviewer: abdullah alamoudi Gerrit-HasComments: No