Mailing-List: contact notifications-help@asterixdb.apache.org; run by ezmlm
Precedence: bulk
Reply-To: dev@asterixdb.apache.org
Date: Tue, 10 Oct 2017 11:32:02 -0700
From: "Steven Jacobs (Code Review)" <do-not-reply@asterixdb.incubator.apache.org>
CC: Ildar Absalyamov <ildar.absalyamov@gmail.com>,
	abdullah alamoudi <bamousaa@gmail.com>,
	Xikui Wang <xkkwww@gmail.com>, Till Westmann <tillw@apache.org>,
	Dmitry Lychagin <dmitry.lychagin@couchbase.com>,
	Jenkins <jenkins@fulliautomatix.ics.uci.edu>
Reply-To: sjaco002@ucr.edu
Subject: Change in asterixdb[master]: [HYR,RT,CLUS] Fixes and Improvements for predistributed Jobs
In-Reply-To: <gerrit.1506970371206.I8f493c1fa977d07dfe8a875f9ebe9515d01d1473@asterix-gerrit.ics.uci.edu>
References: <gerrit.1506970371206.I8f493c1fa977d07dfe8a875f9ebe9515d01d1473@asterix-gerrit.ics.uci.edu>
MIME-Version: 1.0
Content-Type: text/plain; charset=UTF-8
Content-Transfer-Encoding: 8bit
Content-Disposition: inline
User-Agent: Gerrit/2.12.7
Message-Id: <20171010183202.57A3F100726@vitalstatistix.ics.uci.edu>
archived-at: Tue, 10 Oct 2017 18:32:08 -0000

Steven Jacobs has posted comments on this change.

Change subject: [HYR,RT,CLUS] Fixes and Improvements for predistributed Jobs
......................................................................


Patch Set 6:

(2 comments)

https://asterix-gerrit.ics.uci.edu/#/c/2045/6//COMMIT_MSG
Commit Message:

Line 12: Allow predistributed jobs to have a new jobId for each execution
> If this patch is not intended for running multiple instances of the same pj
Okay, maybe you might know more of the details about why I still see issues with simultaneous execution then. Let's talk more about this in person or on Skype.


https://asterix-gerrit.ics.uci.edu/#/c/2045/6/hyracks-fullstack/hyracks/hyracks-control/hyracks-control-cc/src/main/java/org/apache/hyracks/control/cc/ClientInterfaceIPCI.java
File hyracks-fullstack/hyracks/hyracks-control/hyracks-control-cc/src/main/java/org/apache/hyracks/control/cc/ClientInterfaceIPCI.java:

Line 56:     private long predistributedId = 0;
> What if someone accidentally reset it or reassigned it somewhere, it would 
Okay, I'll make this change for the next patchset.


-- 
To view, visit https://asterix-gerrit.ics.uci.edu/2045
To unsubscribe, visit https://asterix-gerrit.ics.uci.edu/settings

Gerrit-MessageType: comment
Gerrit-Change-Id: I8f493c1fa977d07dfe8a875f9ebe9515d01d1473
Gerrit-PatchSet: 6
Gerrit-Project: asterixdb
Gerrit-Branch: master
Gerrit-Owner: Steven Jacobs <sjaco002@ucr.edu>
Gerrit-Reviewer: Dmitry Lychagin <dmitry.lychagin@couchbase.com>
Gerrit-Reviewer: Ildar Absalyamov <ildar.absalyamov@gmail.com>
Gerrit-Reviewer: Jenkins <jenkins@fulliautomatix.ics.uci.edu>
Gerrit-Reviewer: Steven Jacobs <sjaco002@ucr.edu>
Gerrit-Reviewer: Till Westmann <tillw@apache.org>
Gerrit-Reviewer: Xikui Wang <xkkwww@gmail.com>
Gerrit-Reviewer: abdullah alamoudi <bamousaa@gmail.com>
Gerrit-HasComments: Yes