Return-Path: X-Original-To: archive-asf-public-internal@cust-asf2.ponee.io Delivered-To: archive-asf-public-internal@cust-asf2.ponee.io Received: from cust-asf.ponee.io (cust-asf.ponee.io [163.172.22.183]) by cust-asf2.ponee.io (Postfix) with ESMTP id 9F11D200D21 for ; Mon, 2 Oct 2017 01:38:15 +0200 (CEST) Received: by cust-asf.ponee.io (Postfix) id 9D9F11609D9; Sun, 1 Oct 2017 23:38:15 +0000 (UTC) Delivered-To: archive-asf-public@cust-asf.ponee.io Received: from mail.apache.org (hermes.apache.org [140.211.11.3]) by cust-asf.ponee.io (Postfix) with SMTP id E32AC1609C8 for ; Mon, 2 Oct 2017 01:38:14 +0200 (CEST) Received: (qmail 45089 invoked by uid 500); 1 Oct 2017 23:38:13 -0000 Mailing-List: contact notifications-help@asterixdb.apache.org; run by ezmlm Precedence: bulk List-Help: List-Unsubscribe: List-Post: List-Id: Reply-To: dev@asterixdb.apache.org Delivered-To: mailing list notifications@asterixdb.apache.org Received: (qmail 45080 invoked by uid 99); 1 Oct 2017 23:38:13 -0000 Received: from pnap-us-west-generic-nat.apache.org (HELO spamd1-us-west.apache.org) (209.188.14.142) by apache.org (qpsmtpd/0.29) with ESMTP; Sun, 01 Oct 2017 23:38:13 +0000 Received: from localhost (localhost [127.0.0.1]) by spamd1-us-west.apache.org (ASF Mail Server at spamd1-us-west.apache.org) with ESMTP id 86CF0D79CE for ; Sun, 1 Oct 2017 23:38:13 +0000 (UTC) X-Virus-Scanned: Debian amavisd-new at spamd1-us-west.apache.org X-Spam-Flag: NO X-Spam-Score: 2.126 X-Spam-Level: ** X-Spam-Status: No, score=2.126 tagged_above=-999 required=6.31 tests=[MISSING_HEADERS=1.207, SPF_FAIL=0.919] autolearn=disabled Received: from mx1-lw-us.apache.org ([10.40.0.8]) by localhost (spamd1-us-west.apache.org [10.40.0.7]) (amavisd-new, port 10024) with ESMTP id 08maQpvgpfTQ for ; Sun, 1 Oct 2017 23:38:12 +0000 (UTC) Received: from vitalstatistix.ics.uci.edu (vitalstatistix.ics.uci.edu [128.195.52.38]) by mx1-lw-us.apache.org (ASF Mail Server at mx1-lw-us.apache.org) with ESMTP id A46A15FC8A for ; Sun, 1 Oct 2017 23:38:12 +0000 (UTC) Received: from localhost (localhost [127.0.0.1]) by vitalstatistix.ics.uci.edu (Postfix) with ESMTP id 3F78A100B3A; Sun, 1 Oct 2017 16:38:12 -0700 (PDT) Date: Sun, 1 Oct 2017 16:38:12 -0700 From: "Xikui Wang (Code Review)" CC: Jenkins , Till Westmann , Michael Blow Reply-To: xkkwww@gmail.com X-Gerrit-MessageType: comment Subject: Change in asterixdb[master]: [ASTERIXDB-2117][SQL] Eliminating '#' for line comment in SQLPP X-Gerrit-Change-Id: I8fc25ad9cd4923edf0359cf90b466c8fa09a6485 X-Gerrit-ChangeURL: X-Gerrit-Commit: 0b6487f2f9c72906402aa9fbd28dc81f1618e7c3 In-Reply-To: References: MIME-Version: 1.0 Content-Type: text/plain; charset=UTF-8 Content-Transfer-Encoding: 8bit Content-Disposition: inline User-Agent: Gerrit/2.12.7 Message-Id: <20171001233812.3F78A100B3A@vitalstatistix.ics.uci.edu> archived-at: Sun, 01 Oct 2017 23:38:15 -0000 Xikui Wang has posted comments on this change. Change subject: [ASTERIXDB-2117][SQL] Eliminating '#' for line comment in SQLPP ...................................................................... Patch Set 1: (1 comment) https://asterix-gerrit.ics.uci.edu/#/c/2037/1//COMMIT_MSG Commit Message: PS1, Line 7: Deprecating > This change seems to be eliminating, not deprecating... Please consider u Agree! Updated and rebased. -- To view, visit https://asterix-gerrit.ics.uci.edu/2037 To unsubscribe, visit https://asterix-gerrit.ics.uci.edu/settings Gerrit-MessageType: comment Gerrit-Change-Id: I8fc25ad9cd4923edf0359cf90b466c8fa09a6485 Gerrit-PatchSet: 1 Gerrit-Project: asterixdb Gerrit-Branch: master Gerrit-Owner: Xikui Wang Gerrit-Reviewer: Jenkins Gerrit-Reviewer: Michael Blow Gerrit-Reviewer: Till Westmann Gerrit-Reviewer: Xikui Wang Gerrit-HasComments: Yes