asterixdb-notifications mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From "abdullah alamoudi (Code Review)" <do-not-re...@asterixdb.incubator.apache.org>
Subject Change in asterixdb[master]: [NO ISSUE][OTH] Appender flush call with tracing call normal...
Date Wed, 18 Oct 2017 04:49:24 GMT
abdullah alamoudi has uploaded a new change for review.

  https://asterix-gerrit.ics.uci.edu/2080

Change subject: [NO ISSUE][OTH] Appender flush call with tracing call normal flush
......................................................................

[NO ISSUE][OTH] Appender flush call with tracing call normal flush

- user model changes: no
- storage format changes: no
- interface changes: no

details:
- The flush with tracing now calls the normal flush. This enables
  sub appenders overriding the flush call to maintain correctness.

Change-Id: I3f649798fa4cac049f66cc3621acdb28b1c94694
---
M hyracks-fullstack/hyracks/hyracks-dataflow-common/src/main/java/org/apache/hyracks/dataflow/common/comm/io/AbstractFrameAppender.java
1 file changed, 4 insertions(+), 4 deletions(-)


  git pull ssh://asterix-gerrit.ics.uci.edu:29418/asterixdb refs/changes/80/2080/1

diff --git a/hyracks-fullstack/hyracks/hyracks-dataflow-common/src/main/java/org/apache/hyracks/dataflow/common/comm/io/AbstractFrameAppender.java
b/hyracks-fullstack/hyracks/hyracks-dataflow-common/src/main/java/org/apache/hyracks/dataflow/common/comm/io/AbstractFrameAppender.java
index 13632f0..a377d75 100644
--- a/hyracks-fullstack/hyracks/hyracks-dataflow-common/src/main/java/org/apache/hyracks/dataflow/common/comm/io/AbstractFrameAppender.java
+++ b/hyracks-fullstack/hyracks/hyracks-dataflow-common/src/main/java/org/apache/hyracks/dataflow/common/comm/io/AbstractFrameAppender.java
@@ -120,10 +120,10 @@
     public void flush(IFrameWriter writer, ITracer tracer, String name, String cat, String
args)
             throws HyracksDataException {
         final long tid = ITracer.check(tracer).durationB(name, cat, args);
-        if (tupleCount > 0) {
-            write(writer, true);
+        try {
+            flush(writer);
+        } finally {
+            ITracer.check(tracer).durationE(tid, args);
         }
-        writer.flush();
-        ITracer.check(tracer).durationE(tid, args);
     }
 }

-- 
To view, visit https://asterix-gerrit.ics.uci.edu/2080
To unsubscribe, visit https://asterix-gerrit.ics.uci.edu/settings

Gerrit-MessageType: newchange
Gerrit-Change-Id: I3f649798fa4cac049f66cc3621acdb28b1c94694
Gerrit-PatchSet: 1
Gerrit-Project: asterixdb
Gerrit-Branch: master
Gerrit-Owner: abdullah alamoudi <bamousaa@gmail.com>

Mime
View raw message