asterixdb-notifications mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From "abdullah alamoudi (Code Review)" <do-not-re...@asterixdb.incubator.apache.org>
Subject Change in asterixdb[master]: [NO ISSUE][ING] Make resume attempt on the same suspend/resu...
Date Wed, 25 Oct 2017 20:54:04 GMT
abdullah alamoudi has posted comments on this change.

Change subject: [NO ISSUE][ING] Make resume attempt on the same suspend/resume thread
......................................................................


Patch Set 1:

(6 comments)

https://asterix-gerrit.ics.uci.edu/#/c/2104/1/asterixdb/asterix-app/src/main/java/org/apache/asterix/app/active/ActiveEntityEventsListener.java
File asterixdb/asterix-app/src/main/java/org/apache/asterix/app/active/ActiveEntityEventsListener.java:

PS1, Line 508:       } catch (InterruptedException e) {
             :                 LOGGER.log(Level.WARNING, "Failure while attempting to resume
" + entityId, e);
             :                 Thread.currentThread().interrupt();
             :                 throw HyracksDataException.create(e);
             :       
> remove
Done


Line 513:                 LOGGER.log(Level.WARNING, "Failure while attempting to resume "
+ entityId, e);
> add something indicating will attempt to recovery
Added from within if recovery task was submitted. since this is not always the case.


https://asterix-gerrit.ics.uci.edu/#/c/2104/1/asterixdb/asterix-app/src/main/java/org/apache/asterix/app/active/RecoveryTask.java
File asterixdb/asterix-app/src/main/java/org/apache/asterix/app/active/RecoveryTask.java:

PS1, Line 82: Void
> /void/
Done


PS1, Line 83: , InterruptedException
> remove
Done


PS1, Line 107:                         .submit(() -> {
             :                             IRetryPolicy policy = retryPolicyFactory.create(listener);
             :                             doRecover(policy);
             :                             return null;
             :                         });
> use expression lambda for brevity?
Done


PS1, Line 115:         return null;
> remove
Done


-- 
To view, visit https://asterix-gerrit.ics.uci.edu/2104
To unsubscribe, visit https://asterix-gerrit.ics.uci.edu/settings

Gerrit-MessageType: comment
Gerrit-Change-Id: Icc801923b167862286a5104b199cdc43e76096c8
Gerrit-PatchSet: 1
Gerrit-Project: asterixdb
Gerrit-Branch: master
Gerrit-Owner: abdullah alamoudi <bamousaa@gmail.com>
Gerrit-Reviewer: Jenkins <jenkins@fulliautomatix.ics.uci.edu>
Gerrit-Reviewer: Michael Blow <mblow@apache.org>
Gerrit-Reviewer: Murtadha Hubail <mhubail@apache.org>
Gerrit-Reviewer: abdullah alamoudi <bamousaa@gmail.com>
Gerrit-HasComments: Yes

Mime
View raw message