asterixdb-notifications mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From "Michael Blow (Code Review)" <do-not-re...@asterixdb.incubator.apache.org>
Subject Change in asterixdb[master]: [ASTERIXDB-2132] Replace ITracer.check
Date Tue, 24 Oct 2017 15:40:28 GMT
Michael Blow has posted comments on this change.

Change subject: [ASTERIXDB-2132] Replace ITracer.check
......................................................................


Patch Set 8:

(4 comments)

https://asterix-gerrit.ics.uci.edu/#/c/2087/8/asterixdb/asterix-external-data/src/main/java/org/apache/asterix/external/operators/FeedMetaStoreNodePushable.java
File asterixdb/asterix-external-data/src/main/java/org/apache/asterix/external/operators/FeedMetaStoreNodePushable.java:

PS8, Line 110: "Process-Frame"
doesn't need to be in this change, but should we have a class in Asterix (and Hyracks) where
we park category names?


https://asterix-gerrit.ics.uci.edu/#/c/2087/8/hyracks-fullstack/hyracks/hyracks-storage-am-lsm-common/src/main/java/org/apache/hyracks/storage/am/lsm/common/impls/TracedIOOperation.java
File hyracks-fullstack/hyracks/hyracks-storage-am-lsm-common/src/main/java/org/apache/hyracks/storage/am/lsm/common/impls/TracedIOOperation.java:

PS8, Line 50: .name().toLowerCase()
not necessary for this change, but should we add this as a member to the enum to avoid the
repeated calculation?


https://asterix-gerrit.ics.uci.edu/#/c/2087/8/hyracks-fullstack/hyracks/hyracks-util/src/main/java/org/apache/hyracks/util/trace/Tracer.java
File hyracks-fullstack/hyracks/hyracks-util/src/main/java/org/apache/hyracks/util/trace/Tracer.java:

PS8, Line 72:  + 
should we include some separator here?  how often is this called?  should we express the categories
as a set of strings?


PS8, Line 87: (categories & cat) != 0L
this is a beautiful thing


-- 
To view, visit https://asterix-gerrit.ics.uci.edu/2087
To unsubscribe, visit https://asterix-gerrit.ics.uci.edu/settings

Gerrit-MessageType: comment
Gerrit-Change-Id: I3f26ae988d3786ef4ddb17e8fe78f911e7e628f1
Gerrit-PatchSet: 8
Gerrit-Project: asterixdb
Gerrit-Branch: master
Gerrit-Owner: Till Westmann <tillw@apache.org>
Gerrit-Reviewer: Anon. E. Moose #1000171
Gerrit-Reviewer: Jenkins <jenkins@fulliautomatix.ics.uci.edu>
Gerrit-Reviewer: Michael Blow <mblow@apache.org>
Gerrit-Reviewer: abdullah alamoudi <bamousaa@gmail.com>
Gerrit-HasComments: Yes

Mime
View raw message