asterixdb-notifications mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From "Luo Chen (Code Review)" <do-not-re...@asterixdb.incubator.apache.org>
Subject Change in asterixdb[master]: [ASTERIXDB-2128] Fix bloomfilter during index search
Date Fri, 20 Oct 2017 23:17:18 GMT
Luo Chen has posted comments on this change.

Change subject: [ASTERIXDB-2128] Fix bloomfilter during index search
......................................................................


Patch Set 6:

(4 comments)

https://asterix-gerrit.ics.uci.edu/#/c/2069/6//COMMIT_MSG
Commit Message:

PS6, Line 19: - Compute murmur hashing during bloom filter check is expensive.
            : Since bloom filters of disk components of an index share the same hash
            : values for a tuple, this patch also separate compute hash from bloom
            : filter check to speed up performance
> not fixed yet? remove and add when fixed?
Done


https://asterix-gerrit.ics.uci.edu/#/c/2069/6/hyracks-fullstack/hyracks/hyracks-storage-am-bloomfilter/src/main/java/org/apache/hyracks/storage/am/bloomfilter/impls/BloomFilter.java
File hyracks-fullstack/hyracks/hyracks-storage-am-bloomfilter/src/main/java/org/apache/hyracks/storage/am/bloomfilter/impls/BloomFilter.java:

PS6, Line 89:         MurmurHash128Bit.hash3_x64_128(tuple, keyFields, SEED, hashes);
> Revert the unchanged line?
Done


https://asterix-gerrit.ics.uci.edu/#/c/2069/6/hyracks-fullstack/hyracks/hyracks-storage-am-lsm-invertedindex/src/main/java/org/apache/hyracks/storage/am/lsm/invertedindex/impls/LSMInvertedIndexRangeSearchCursor.java
File hyracks-fullstack/hyracks/hyracks-storage-am-lsm-invertedindex/src/main/java/org/apache/hyracks/storage/am/lsm/invertedindex/impls/LSMInvertedIndexRangeSearchCursor.java:

PS6, Line 45: protected boolean hashComputed = false;
> not used?
Done


PS6, Line 106: hashComputed = false;
> remove?
Done


-- 
To view, visit https://asterix-gerrit.ics.uci.edu/2069
To unsubscribe, visit https://asterix-gerrit.ics.uci.edu/settings

Gerrit-MessageType: comment
Gerrit-Change-Id: I90ab0d0b2da0028e0ec3cfa94d21881318293ff7
Gerrit-PatchSet: 6
Gerrit-Project: asterixdb
Gerrit-Branch: master
Gerrit-Owner: Luo Chen <cluo8@uci.edu>
Gerrit-Reviewer: Anon. E. Moose #1000171
Gerrit-Reviewer: Ian Maxon <imaxon@apache.org>
Gerrit-Reviewer: Jenkins <jenkins@fulliautomatix.ics.uci.edu>
Gerrit-Reviewer: Luo Chen <cluo8@uci.edu>
Gerrit-Reviewer: abdullah alamoudi <bamousaa@gmail.com>
Gerrit-HasComments: Yes

Mime
View raw message