asterixdb-notifications mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From "Xikui Wang (Code Review)" <do-not-re...@asterixdb.incubator.apache.org>
Subject Change in asterixdb[master]: [ASTERIXDB-1983] Feed pipeline refactoring for SQL++
Date Fri, 20 Oct 2017 19:18:49 GMT
Xikui Wang has posted comments on this change.

Change subject: [ASTERIXDB-1983] Feed pipeline refactoring for SQL++
......................................................................


Patch Set 8:

(5 comments)

comments from abdullah.

https://asterix-gerrit.ics.uci.edu/#/c/2059/8//COMMIT_MSG
Commit Message:

Line 15: very well, and there is a overhead for parsign the query everytime.
an, parsing


Line 26: 5. Change the default behavior of feed to be upsert instead of upsert.
instead of insert


https://asterix-gerrit.ics.uci.edu/#/c/2059/8/asterixdb/asterix-app/src/main/java/org/apache/asterix/app/translator/QueryTranslator.java
File asterixdb/asterix-app/src/main/java/org/apache/asterix/app/translator/QueryTranslator.java:

PS8, Line 2161: TODO: Chec
create issue too


https://asterix-gerrit.ics.uci.edu/#/c/2059/8/asterixdb/asterix-app/src/main/java/org/apache/asterix/utils/FeedOperations.java
File asterixdb/asterix-app/src/main/java/org/apache/asterix/utils/FeedOperations.java:

PS8, Line 182: List<Expression> addArgs(Object... args) {
             :         List<Expression> argExprs = new ArrayList<>();
             :         for (Object arg : args) {
             :             if (arg instanceof Integer) {
             :                 argExprs.add(new LiteralExpr(new IntegerLiteral((Integer) arg)));
             :             } else if (arg instanceof String) {
             :                 argExprs.add(new LiteralExpr(new StringLiteral((String) arg)));
             :             } else if (arg instanceof VariableExpr) {
             :                 argExprs.add((VariableExpr) arg);
             :             }
             :         }
             :         return argExprs;
             :     }
double check if we already have util method for this


https://asterix-gerrit.ics.uci.edu/#/c/2059/8/asterixdb/asterix-external-data/src/main/java/org/apache/asterix/external/util/FeedConstants.java
File asterixdb/asterix-external-data/src/main/java/org/apache/asterix/external/util/FeedConstants.java:

PS8, Line 26: SIGN
--> signature


-- 
To view, visit https://asterix-gerrit.ics.uci.edu/2059
To unsubscribe, visit https://asterix-gerrit.ics.uci.edu/settings

Gerrit-MessageType: comment
Gerrit-Change-Id: I0ae5a837613780a4d2c90c98139fdc6d5e040cc9
Gerrit-PatchSet: 8
Gerrit-Project: asterixdb
Gerrit-Branch: master
Gerrit-Owner: Xikui Wang <xkkwww@gmail.com>
Gerrit-Reviewer: Anon. E. Moose #1000171
Gerrit-Reviewer: Jenkins <jenkins@fulliautomatix.ics.uci.edu>
Gerrit-Reviewer: Xikui Wang <xkkwww@gmail.com>
Gerrit-Reviewer: abdullah alamoudi <bamousaa@gmail.com>
Gerrit-HasComments: Yes

Mime
View raw message