asterixdb-notifications mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From "Ian Maxon (Code Review)" <do-not-re...@asterixdb.incubator.apache.org>
Subject Change in asterixdb[master]: [ASTERIXDB-1371][FUN][AQL][SQL] Add standard geometry data t...
Date Sat, 14 Oct 2017 23:40:30 GMT
Ian Maxon has posted comments on this change.

Change subject: [ASTERIXDB-1371][FUN][AQL][SQL] Add standard geometry data type and functions
......................................................................


Patch Set 6:

(4 comments)

Has this been benchmarked for memory consumption? I see a lot of places that look like to
me, they will consume memory in proportion to the data perhaps...

https://asterix-gerrit.ics.uci.edu/#/c/2056/6/asterixdb/asterix-om/src/main/java/org/apache/asterix/dataflow/data/nontagged/serde/AGeometrySerializerDeserializer.java
File asterixdb/asterix-om/src/main/java/org/apache/asterix/dataflow/data/nontagged/serde/AGeometrySerializerDeserializer.java:

PS6, Line 49:             OGCGeometry geometry = OGCGeometry
            :                     .createFromOGCStructure(OperatorImportFromWkb.local().executeOGC(0,
buffer, null),
            :                             SpatialReference.create(4326))
What are the 0, null, and 4326 here for? Can we get them defined as static final variables
if they indeed are?


https://asterix-gerrit.ics.uci.edu/#/c/2056/6/asterixdb/asterix-om/src/main/java/org/apache/asterix/om/base/AGeometry.java
File asterixdb/asterix-om/src/main/java/org/apache/asterix/om/base/AGeometry.java:

Line 73:             throw new RuntimeException(e);
> CRITICAL SonarQube violation:
+1, should throw something else preferably...


https://asterix-gerrit.ics.uci.edu/#/c/2056/6/asterixdb/asterix-om/src/main/java/org/apache/asterix/om/utils/NonTaggedFormatUtil.java
File asterixdb/asterix-om/src/main/java/org/apache/asterix/om/utils/NonTaggedFormatUtil.java:

PS6, Line 200: AInt32SerializerDeserializer
Wait, what? Why AInt32?


https://asterix-gerrit.ics.uci.edu/#/c/2056/6/asterixdb/asterix-runtime/src/main/java/org/apache/asterix/runtime/aggregates/std/STUnionAggregateFunction.java
File asterixdb/asterix-runtime/src/main/java/org/apache/asterix/runtime/aggregates/std/STUnionAggregateFunction.java:

PS6, Line 66: geometry = new OGCPoint(new Point(), SpatialReference.create(4326));
            :     }
Again what is the 4326 about?


-- 
To view, visit https://asterix-gerrit.ics.uci.edu/2056
To unsubscribe, visit https://asterix-gerrit.ics.uci.edu/settings

Gerrit-MessageType: comment
Gerrit-Change-Id: I9cddeffea42e85469b6fc38f361bd98e64025289
Gerrit-PatchSet: 6
Gerrit-Project: asterixdb
Gerrit-Branch: master
Gerrit-Owner: Ahmed Eldawy <eldawy@cs.umn.edu>
Gerrit-Reviewer: Anon. E. Moose #1000171
Gerrit-Reviewer: Ian Maxon <imaxon@apache.org>
Gerrit-Reviewer: Jenkins <jenkins@fulliautomatix.ics.uci.edu>
Gerrit-Reviewer: Xikui Wang <xkkwww@gmail.com>
Gerrit-HasComments: Yes

Mime
View raw message